Fix sign-compare warnings arising from port/simd.h

j-naylor · j-naylor · commit 73b9d051c607 · 2022-09-04T09:23:57.000+07:00
Noted while building an extension using -Wsign-compare. Per gripe from Pavel Stehule Discussion: https://www.postgresql.org/message-id/CAFj8pRAagKQHfw71aQbL8PbL0S_360M61V0_vPqJXbpUFvqnRA%40mail.gmail.com
diff --git a/src/include/port/simd.h b/src/include/port/simd.h
@@ -165,7 +165,7 @@ vector8_has(const Vector8 v, const uint8 c)
 #ifdef USE_ASSERT_CHECKING
 	bool		assert_result = false;
 
-	for (int i = 0; i < sizeof(Vector8); i++)
+	for (Size i = 0; i < sizeof(Vector8); i++)
 	{
 		if (((const uint8 *) &v)[i] == c)
 		{
@@ -216,7 +216,7 @@ vector8_has_le(const Vector8 v, const uint8 c)
 #ifdef USE_ASSERT_CHECKING
 	bool		assert_result = false;
 
-	for (int i = 0; i < sizeof(Vector8); i++)
+	for (Size i = 0; i < sizeof(Vector8); i++)
 	{
 		if (((const uint8 *) &v)[i] <= c)
 		{
@@ -239,7 +239,7 @@ vector8_has_le(const Vector8 v, const uint8 c)
 	else
 	{
 		/* one byte at a time */
-		for (int i = 0; i < sizeof(Vector8); i++)
+		for (Size i = 0; i < sizeof(Vector8); i++)
 		{
 			if (((const uint8 *) &v)[i] <= c)
 			{

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ vector8_has(const Vector8 v, const uint8 c)`
`165`	`165`	`#ifdef USE_ASSERT_CHECKING`
`166`	`166`	`bool assert_result = false;`
`167`	`167`
`168`		`- for (int i = 0; i < sizeof(Vector8); i++)`
	`168`	`+ for (Size i = 0; i < sizeof(Vector8); i++)`
`169`	`169`	`{`
`170`	`170`	`if (((const uint8 *) &v)[i] == c)`
`171`	`171`	`{`
`@@ -216,7 +216,7 @@ vector8_has_le(const Vector8 v, const uint8 c)`
`216`	`216`	`#ifdef USE_ASSERT_CHECKING`
`217`	`217`	`bool assert_result = false;`
`218`	`218`
`219`		`- for (int i = 0; i < sizeof(Vector8); i++)`
	`219`	`+ for (Size i = 0; i < sizeof(Vector8); i++)`
`220`	`220`	`{`
`221`	`221`	`if (((const uint8 *) &v)[i] <= c)`
`222`	`222`	`{`
`@@ -239,7 +239,7 @@ vector8_has_le(const Vector8 v, const uint8 c)`
`239`	`239`	`else`
`240`	`240`	`{`
`241`	`241`	`/* one byte at a time */`
`242`		`- for (int i = 0; i < sizeof(Vector8); i++)`
	`242`	`+ for (Size i = 0; i < sizeof(Vector8); i++)`
`243`	`243`	`{`
`244`	`244`	`if (((const uint8 *) &v)[i] <= c)`
`245`	`245`	`{`