[PGPRO-9026] Added check for attached column

Author: kovdb75

expected/rum_validate.out

@@ -114,9 +114,19 @@ SET enable_indexscan=on;
 SELECT a
 	FROM test_rum
 	WHERE a @@ to_tsquery('pg_catalog.english', 'bar')
-	ORDER BY a <=> (to_tsquery('pg_catalog.english', 'bar'),0)
+	ORDER BY a <=> (to_tsquery('pg_catalog.english', 'bar'),0);
               a               
 ------------------------------
  'bar':2,8 'foo':1,3,6 'qq':7
 (1 row)
 
+-- PGPRO-9026: column and attached column cannot be the same
+CREATE TABLE test_array (i int2[]);
+CREATE INDEX idx_array ON test_array USING rum (i rum_anyarray_addon_ops) WITH (attach = 'i', to = 'i');
+ERROR:  column "i" and attached column cannot be the same
+SELECT * FROM test_array WHERE i && '{1}';
+ i 
+---
+(0 rows)
+
+DROP TABLE test_array;

sql/rum_validate.sql

@@ -58,4 +58,10 @@ SET enable_indexscan=on;
 SELECT a
 	FROM test_rum
 	WHERE a @@ to_tsquery('pg_catalog.english', 'bar')
-	ORDER BY a <=> (to_tsquery('pg_catalog.english', 'bar'),0)
+	ORDER BY a <=> (to_tsquery('pg_catalog.english', 'bar'),0);
+
+-- PGPRO-9026: column and attached column cannot be the same
+CREATE TABLE test_array (i int2[]);
+CREATE INDEX idx_array ON test_array USING rum (i rum_anyarray_addon_ops) WITH (attach = 'i', to = 'i');
+SELECT * FROM test_array WHERE i && '{1}';
+DROP TABLE test_array;

src/rumutil.c

@@ -211,6 +211,9 @@ initRumState(RumState * state, Relation index)
 
 			if (!AttributeNumberIsValid(state->attrnAddToColumn))
 				elog(ERROR, "attribute \"%s\" is not found in index", colname);
+
+			if (state->attrnAddToColumn == state->attrnAttachColumn)
+				elog(ERROR, "column \"%s\" and attached column cannot be the same", colname);
 		}
 
 		if (!(AttributeNumberIsValid(state->attrnAttachColumn) &&