Sometimes copyItem could be uninitialized

Artur Zakirov · Artur Zakirov · commit 78ce88248779 · 2016-12-12T15:18:07.000+03:00
diff --git a/src/rumdatapage.c b/src/rumdatapage.c
@@ -884,7 +884,7 @@ dataPlaceToPage(RumBtree btree, Page page, OffsetNumber off)
 		 */
 		while(42)
 		{
-			int cmp;
+			int			cmp = 0;
 
 			/* get next item to copy if we pushed it on previous loop */
 			if (copyItemEmpty == true && off <= maxoff)
@@ -932,7 +932,7 @@ dataPlaceToPage(RumBtree btree, Page page, OffsetNumber off)
 				break;
 			}
 
-			if (cmp <= 0)
+			if (cmp <= 0 && ItemPointerIsValid(&copyItem.iptr))
 			{
 				ptr = rumPlaceToDataPageLeaf(ptr, btree->entryAttnum,
 											 &copyItem,

Original file line number	Diff line number	Diff line change
`@@ -884,7 +884,7 @@ dataPlaceToPage(RumBtree btree, Page page, OffsetNumber off)`
`884`	`884`	`*/`
`885`	`885`	`while(42)`
`886`	`886`	`{`
`887`		`- int cmp;`
	`887`	`+ int cmp = 0;`
`888`	`888`
`889`	`889`	`/* get next item to copy if we pushed it on previous loop */`
`890`	`890`	`if (copyItemEmpty == true && off <= maxoff)`
`@@ -932,7 +932,7 @@ dataPlaceToPage(RumBtree btree, Page page, OffsetNumber off)`
`932`	`932`	`break;`
`933`	`933`	`}`
`934`	`934`
`935`		`- if (cmp <= 0)`
	`935`	`+ if (cmp <= 0 && ItemPointerIsValid(&copyItem.iptr))`
`936`	`936`	`{`
`937`	`937`	`ptr = rumPlaceToDataPageLeaf(ptr, btree->entryAttnum,`
`938`	`938`	`&copyItem,`