Fixes per clang analyzer complains

Author: za-arthur

src/rum_arr_utils.c

@@ -733,6 +733,7 @@ cmpAscArrayElem(const void *a, const void *b, void *arg)
 {
 	FmgrInfo	*cmpFunc = (FmgrInfo*)arg;
 
+	Assert(a && b);
 	return DatumGetInt32(FunctionCall2Coll(cmpFunc, DEFAULT_COLLATION_OID, *(Datum*)a, *(Datum*)b));
 }
 

src/rum_ts_utils.c

@@ -1242,7 +1242,7 @@ calc_score_docr(float4 *arrdata, DocRepresentation *doc, uint32 doclen,
 		int			new_cover_key = 0;
 		int			nitems = 0;
 
-		while (ptr <= ext.end)
+		while (ptr && ptr <= ext.end)
 		{
 			InvSum += arrdata[ptr->wclass];
 			/* SK: Quick and dirty hash key. Hope collisions will be not too frequent. */

src/rumget.c

@@ -1112,7 +1112,7 @@ entryGetNextItemList(RumState * rumstate, RumScanEntry entry, Snapshot snapshot)
 		entry->isFinished = setListPositionScanEntry(rumstate, entry);
 	}
 
-	Assert(entry->nlist > 0);
+	Assert(entry->nlist > 0 && entry->list);
 
 	entry->curItem = entry->list[entry->offset];
 	entry->offset += entry->scanDirection;
@@ -1169,7 +1169,7 @@ entryGetItem(RumState * rumstate, RumScanEntry entry, bool *nextEntryList, Snaps
 			if (!ItemPointerIsMin(&entry->collectRumItem.item.iptr))
 				collected = entry->collectRumItem;
 			else
-				ItemPointerSetMin(&collected.item.iptr);
+				MemSet(&collected, 0, sizeof(collected));
 
 			ItemPointerSetMin(&entry->curItem.iptr);
 

src/rumsort.c

@@ -2426,7 +2426,6 @@ mergeruns(RumTuplesortstate *state)
 	else
 	{
 		numInputTapes = state->tapeRange;
-		numTapes = state->maxTapes;
 	}
 
 	state->read_buffer_size = Max(state->availMem / numInputTapes, 0);

src/rumvacuum.c

@@ -53,6 +53,7 @@ rumVacuumPostingList(RumVacuumState * gvs, OffsetNumber attnum, Pointer src,
 				prev,
 				ptr = src;
 
+	*newSize = 0;
 	ItemPointerSetMin(&item.iptr);
 
 	/*

travis/mk_dockerfile.sh

@@ -4,7 +4,7 @@ if [ -z ${PG_VERSION+x} ]; then
 fi
 
 if [ -z ${LEVEL+x} ]; then
-	LEVEL=scan-build
+	LEVEL=standard
 fi
 
 echo PG_VERSION=${PG_VERSION}

travis/run_tests.sh

@@ -5,7 +5,6 @@
 #
 # supported levels:
 #		* standard
-#		* scan-build
 #		* hardcore
 #
 
@@ -60,8 +59,7 @@ fi
 pg_config
 
 # perform code checks if asked to
-if [ "$LEVEL" = "scan-build" ] || \
-   [ "$LEVEL" = "hardcore" ]; then
+if [ "$LEVEL" = "hardcore" ]; then
 
 	# perform static analyzis
 	scan-build --status-bugs make USE_PGXS=1 || status=$?