Added test for Publication.add_tables()

Author: zilder

testgres/pubsub.py

@@ -27,16 +27,16 @@ def __init__(self, name, node, tables=None, dbname=None, username=None):
         # create publication in database
         t = "table " + ", ".join(tables) if tables else "all tables"
         query = "create publication {} for {}"
-        node.safe_psql(query.format(name, t),
-                       dbname=dbname,
-                       username=username)
+        node.safe_psql(query.format(name, t), dbname=dbname, username=username)
 
     def drop(self, dbname=None, username=None):
         """
         Drop publication
         """
-        self.node.safe_psql("drop publication {}".format(self.name),
-                            dbname=dbname, username=username)
+        self.node.safe_psql(
+            "drop publication {}".format(self.name),
+            dbname=dbname,
+            username=username)
 
     def add_tables(self, tables, dbname=None, username=None):
         """
@@ -49,9 +49,10 @@ def add_tables(self, tables, dbname=None, username=None):
             raise ValueError("Tables list is empty")
 
         query = "alter publication {} add table {}"
-        self.node.safe_psql(query.format(self.name, ", ".join(tables)),
-                            dbname=dbname or self.dbname,
-                            username=username or self.username)
+        self.node.safe_psql(
+            query.format(self.name, ", ".join(tables)),
+            dbname=dbname or self.dbname,
+            username=username or self.username)
 
 
 class Subscription(object):
@@ -87,8 +88,8 @@ def __init__(self,
         }
 
         query = (
-            "create subscription {} connection '{}' publication {}"
-        ).format(name, options_string(**conninfo), self.pub.name)
+            "create subscription {} connection '{}' publication {}").format(
+                name, options_string(**conninfo), self.pub.name)
 
         # additional parameters
         if kwargs:
@@ -101,34 +102,33 @@ def disable(self, dbname=None, username=None):
         Disables the running subscription.
         """
         query = "alter subscription {} disable"
-        self.node.safe_psql(query.format(self.name),
-                            dbname=None,
-                            username=None)
+        self.node.safe_psql(query.format(self.name), dbname=None, username=None)
 
     def enable(self, dbname=None, username=None):
         """
         Enables the previously disabled subscription.
         """
         query = "alter subscription {} enable"
-        self.node.safe_psql(query.format(self.name),
-                            dbname=None,
-                            username=None)
+        self.node.safe_psql(query.format(self.name), dbname=None, username=None)
 
     def refresh(self, copy_data=True, dbname=None, username=None):
         """
         Disables the running subscription.
         """
         query = "alter subscription {} refresh publication with (copy_data={})"
-        self.node.safe_psql(query.format(self.name, copy_data),
-                            dbname=dbname,
-                            username=username)
+        self.node.safe_psql(
+            query.format(self.name, copy_data),
+            dbname=dbname,
+            username=username)
 
     def drop(self, dbname=None, username=None):
         """
         Drops subscription
         """
-        self.node.safe_psql("drop subscription {}".format(self.name),
-                            dbname=dbname, username=username)
+        self.node.safe_psql(
+            "drop subscription {}".format(self.name),
+            dbname=dbname,
+            username=username)
 
     def catchup(self, username=None):
         """
@@ -139,8 +139,8 @@ def catchup(self, username=None):
         """
         query = (
             "select pg_current_wal_lsn() - replay_lsn = 0 "
-            "from pg_stat_replication where application_name = '{}'"
-        ).format(self.name)
+            "from pg_stat_replication where application_name = '{}'").format(
+                self.name)
 
         try:
             # wait until this LSN reaches subscriber

tests/test_simple.py

@@ -423,7 +423,7 @@ def test_logical_replication(self):
 
             # Add new tables. Since we added "all tables" to publication
             # (default behaviour of publish() method) we don't need
-            # to explicitely perform pub.add_table()
+            # to explicitely perform pub.add_tables()
             create_table = 'create table test2 (c char)'
             node1.safe_psql(create_table)
             node2.safe_psql(create_table)
@@ -450,6 +450,8 @@ def test_logical_replication(self):
             self.assertListEqual(res, [(1, 1), (2, 2), (3, 3), (4, 4)])
 
             # explicitely add table
+            with self.assertRaises(ValueError):
+                pub.add_tables([])  # fail
             pub.add_tables(['test2'])
             node1.safe_psql('insert into test2 values (\'c\')')
             sub.catchup()