Skip to content

Commit 27e05c2

Browse files
committed
Merge load_dependencies into init.
* This will ensure that `ruby_dependencies` is set, even if `--no-install-deps` is given.
1 parent f3b771c commit 27e05c2

File tree

4 files changed

+12
-40
lines changed

4 files changed

+12
-40
lines changed

share/ruby-install/functions.sh

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,11 @@ source "$ruby_install_dir/checksums.sh"
77
#
88
function pre_install() { return; }
99

10-
#
11-
# Loads the dependencies.sh file for the ruby and sets $ruby_dependencies.
12-
#
13-
function load_dependencies()
14-
{
15-
source "$ruby_install_dir/$ruby/dependencies.sh"
16-
}
17-
1810
#
1911
# Install the ruby's dependencies.
2012
#
2113
function install_deps()
2214
{
23-
load_dependencies
24-
2515
if (( ${#ruby_dependencies[@]} > 0 )); then
2616
log "Installing dependencies for $ruby $ruby_version ..."
2717
install_packages "${ruby_dependencies[@]}" || return $?

share/ruby-install/ruby-install.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,9 @@ function init()
288288
warn "Unknown $ruby version $ruby_version. Proceeding anyways ..."
289289
fi
290290

291-
source "$ruby_install_dir/functions.sh" || return $?
292-
source "$ruby_install_dir/$ruby/functions.sh" || return $?
291+
source "$ruby_install_dir/functions.sh" || return $?
292+
source "$ruby_install_dir/$ruby/dependencies.sh" || return $?
293+
source "$ruby_install_dir/$ruby/functions.sh" || return $?
293294

294295
ruby_cache_dir="$ruby_install_cache_dir/$ruby"
295296
install_dir="${install_dir:-$rubies_dir/$ruby-$ruby_version}"

test/functions-tests/load_dependencies_test.sh

Lines changed: 0 additions & 27 deletions
This file was deleted.

test/ruby-install-tests/init_test.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,14 @@ function test_init_with_ruby_url()
6767
assertEquals "did not preserve ruby_url" "$url" "$ruby_url"
6868
}
6969

70+
function test_init_ruby_dependencies()
71+
{
72+
init
73+
74+
assertTrue "did not set \$ruby_dependencies" \
75+
'(( ${#ruby_dependencies[@]} > 0 ))'
76+
}
77+
7078
function test_init_ruby_md5()
7179
{
7280
init
@@ -171,7 +179,7 @@ function test_install_dir()
171179
function tearDown()
172180
{
173181
unset install_dir ruby_cache_dir
174-
unset ruby ruby_version ruby_md5 ruby_archive ruby_url
182+
unset ruby ruby_version ruby_md5 ruby_archive ruby_url ruby_dependencies
175183
}
176184

177185
SHUNIT_PARENT=$0 . $SHUNIT2

0 commit comments

Comments
 (0)