Skip to content

Commit f8c9c33

Browse files
committed
warn user that installation will fail if she doesn't have necessary write permission
1 parent 61a627e commit f8c9c33

File tree

2 files changed

+34
-0
lines changed

2 files changed

+34
-0
lines changed

bin/ruby-install

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ fi
1818

1919
init || exit $?
2020

21+
if [[ ! -w "$install_dir" ]]; then
22+
fail "Installation directory is not writable by the user: $install_dir"
23+
fi
24+
2125
if [[ $no_reinstall -eq 1 ]] && [[ -x "$install_dir/bin/ruby" ]]; then
2226
log "Ruby is already installed into $install_dir"
2327
exit
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
#!/usr/bin/env bash
2+
3+
. ./test/helper.sh
4+
5+
test_install_dir="$test_fixtures_dir/no_permission_warn_test"
6+
7+
function setUp()
8+
{
9+
mkdir -p "$test_install_dir"
10+
chmod -w "$test_install_dir"
11+
}
12+
13+
function test_no_install_when_write_permissions_lacking()
14+
{
15+
local output
16+
local status
17+
18+
output="$(ruby-install --install-dir "$test_install_dir" ruby 2>&1)" || status=$?
19+
20+
assertEquals "did not return 0" 255 $status
21+
assertTrue "did not print a message to STDOUT" \
22+
'[[ "$output" == *"Installation directory is not writable by the user: ${install_dir}"* ]]'
23+
}
24+
25+
function tearDown()
26+
{
27+
rm -rf "$test_install_dir"
28+
}
29+
30+
SHUNIT_PARENT=$0 . $SHUNIT2

0 commit comments

Comments
 (0)