Skip to content

Commit 1799e04

Browse files
committed
Fixing the build. Enabling upstream/dowmstream merges.
1 parent bbef601 commit 1799e04

File tree

3 files changed

+32
-52
lines changed

3 files changed

+32
-52
lines changed

src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2025_0.cs

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,12 @@ public MetalamaDependencyDefinition(
5050
isVersioned,
5151
pullRequestRequiresStatusCheck: pullRequestRequiresStatusCheck,
5252
vcsRootProjectId: vcsRootProjectId ),
53-
isVersioned )
54-
{ }
53+
isVersioned ) { }
5554
}
5655

5756
public static ProductFamily Family { get; } = new( _projectName, "2025.0", DevelopmentDependencies.Family, PostSharpDependencies.V2025_0_GitHub.Family )
5857
{
59-
DockerBaseImage = DockerImages.WindowsServerCore,
60-
UpstreamProductFamily = V2024_2.Family,
61-
62-
// Downstream merge is explicitly disabled for because of repo merge.
63-
// TODO: Implement SuppressDownstream for DependencyDefinition.
64-
// DownstreamProductFamily = V2025_1.Family
58+
DockerBaseImage = DockerImages.WindowsServerCore, DownstreamProductFamily = V2025_1.Family
6559
};
6660

6761
public static DependencyDefinition MetalamaBackstage { get; } =
@@ -107,7 +101,8 @@ public MetalamaDependencyDefinition(
107101
isVersioned: false,
108102
pullRequestRequiresStatusCheck: false )
109103
{
110-
GenerateSnapshotDependency = false,
104+
GenerateSnapshotDependency = false
105+
111106
// SuppressDownstream = true
112107
};
113108

@@ -118,7 +113,8 @@ public MetalamaDependencyDefinition(
118113
MetalamaGitHubOrganization.PostSharp,
119114
customRepositoryName: "Metalama.Framework" )
120115
{
121-
GenerateSnapshotDependency = false,
116+
GenerateSnapshotDependency = false
117+
122118
// SuppressDownstream = true
123119
};
124120

@@ -141,19 +137,13 @@ public MetalamaDependencyDefinition(
141137
new MetalamaDependencyDefinition(
142138
"Metalama.Samples",
143139
VcsProvider.GitHub,
144-
MetalamaGitHubOrganization.Metalama )
145-
{
146-
CodeStyle = "Metalama.Samples"
147-
};
140+
MetalamaGitHubOrganization.Metalama ) { CodeStyle = "Metalama.Samples" };
148141

149142
public static DependencyDefinition TimelessDotNetEngineer { get; } =
150143
new MetalamaDependencyDefinition(
151144
"TimelessDotNetEngineer",
152145
VcsProvider.GitHub,
153-
MetalamaGitHubOrganization.PostSharp )
154-
{
155-
CodeStyle = "Metalama.Samples"
156-
};
146+
MetalamaGitHubOrganization.PostSharp ) { CodeStyle = "Metalama.Samples" };
157147

158148
public static DependencyDefinition MetalamaMigration { get; } =
159149
new MetalamaDependencyDefinition(

src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2025_1.cs

Lines changed: 23 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,12 @@ public MetalamaDependencyDefinition(
5656

5757
public static ProductFamily Family { get; } = new( _projectName, "2025.1", DevelopmentDependencies.Family, PostSharpDependencies.V2025_1_GitHub.Family )
5858
{
59-
DockerBaseImage = DockerImages.WindowsServerCore,
60-
61-
// Upstream is explicitly disabled for because of repo merge.
62-
// TODO: Implement SuppressUpstream for DependencyDefinition.
63-
// UpstreamProductFamily = V2025_0.Family,
59+
DockerBaseImage = DockerImages.WindowsServerCore, UpstreamProductFamily = V2025_0.Family
6460

6561
// DownstreamProductFamily = V2025_2.Family
6662
};
6763

68-
public static DependencyDefinition Consolidated { get; } =
64+
public static DependencyDefinition Consolidated { get; } =
6965
new MetalamaDependencyDefinition(
7066
ProductFamily.ConsolidatedProjectName,
7167
VcsProvider.AzureDevOps,
@@ -75,17 +71,17 @@ public MetalamaDependencyDefinition(
7571

7672
// The release build is intentionally used for the debug configuration because we want dependencies to consume the release
7773
// build, for performance reasons. The debug build will be used only locally, and for this we don't need a configuration here.
78-
public static DependencyDefinition MetalamaCompiler { get; } =
74+
public static DependencyDefinition MetalamaCompiler { get; } =
7975
new MetalamaDependencyDefinition(
8076
"Metalama.Compiler",
8177
VcsProvider.GitHub,
8278
MetalamaGitHubOrganization.Metalama )
8379
{
84-
EngineeringDirectory = "eng-Metalama",
80+
EngineeringDirectory = "eng-Metalama",
8581
PrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSSBuildConfiguration)", "Shipping" )
8682
};
8783

88-
public static DependencyDefinition Metalama { get; } =
84+
public static DependencyDefinition Metalama { get; } =
8985
new MetalamaDependencyDefinition(
9086
"Metalama",
9187
VcsProvider.GitHub,
@@ -103,44 +99,38 @@ public MetalamaDependencyDefinition(
10399
// SuppressUpstream = true
104100
};
105101

106-
public static DependencyDefinition MetalamaVsx { get; } =
107-
new MetalamaDependencyDefinition(
108-
"Metalama.Vsx",
102+
public static DependencyDefinition MetalamaVsx { get; } =
103+
new MetalamaDependencyDefinition(
104+
"Metalama.Vsx",
109105
VcsProvider.AzureDevOps,
110106
null );
111107

112108
public static DependencyDefinition MetalamaSamples { get; } =
113-
new MetalamaDependencyDefinition(
114-
"Metalama.Samples",
109+
new MetalamaDependencyDefinition(
110+
"Metalama.Samples",
115111
VcsProvider.GitHub,
116-
MetalamaGitHubOrganization.Metalama )
117-
{
118-
CodeStyle = "Metalama.Samples"
119-
};
112+
MetalamaGitHubOrganization.Metalama ) { CodeStyle = "Metalama.Samples" };
120113

121114
public static DependencyDefinition TimelessDotNetEngineer { get; } =
122-
new MetalamaDependencyDefinition(
123-
"TimelessDotNetEngineer",
115+
new MetalamaDependencyDefinition(
116+
"TimelessDotNetEngineer",
124117
VcsProvider.GitHub,
125-
MetalamaGitHubOrganization.PostSharp )
126-
{
127-
CodeStyle = "Metalama.Samples"
128-
};
118+
MetalamaGitHubOrganization.PostSharp ) { CodeStyle = "Metalama.Samples" };
129119

130-
public static DependencyDefinition MetalamaCommunity { get; } =
131-
new MetalamaDependencyDefinition(
132-
"Metalama.Community",
120+
public static DependencyDefinition MetalamaCommunity { get; } =
121+
new MetalamaDependencyDefinition(
122+
"Metalama.Community",
133123
VcsProvider.GitHub,
134124
MetalamaGitHubOrganization.PostSharp );
135125

136-
public static DependencyDefinition MetalamaDocumentation { get; } =
126+
public static DependencyDefinition MetalamaDocumentation { get; } =
137127
new MetalamaDependencyDefinition(
138128
"Metalama.Documentation",
139129
VcsProvider.GitHub,
140130
MetalamaGitHubOrganization.Metalama,
141131
false );
142132

143-
public static DependencyDefinition NopCommerce { get; } =
133+
public static DependencyDefinition NopCommerce { get; } =
144134
new MetalamaDependencyDefinition(
145135
"Metalama.Tests.NopCommerce",
146136
VcsProvider.GitHub,
@@ -150,16 +140,16 @@ public MetalamaDependencyDefinition(
150140
vcsRootProjectId: $"Metalama_Metalama{Family.VersionWithoutDots}",
151141
customBranch: $"dev/{Family.Version}" );
152142

153-
public static DependencyDefinition CargoSupport { get; } =
143+
public static DependencyDefinition CargoSupport { get; } =
154144
new MetalamaDependencyDefinition(
155145
"Metalama.Tests.CargoSupport",
156146
VcsProvider.AzureDevOps,
157147
null,
158148
false,
159149
parentCiProjectId: $"Metalama_Metalama{Family.VersionWithoutDots}_MetalamaTests",
160150
vcsRootProjectId: $"Metalama_Metalama{Family.VersionWithoutDots}" );
161-
162-
public static DependencyDefinition DotNetSdkTests { get; } =
151+
152+
public static DependencyDefinition DotNetSdkTests { get; } =
163153
new MetalamaDependencyDefinition(
164154
"Metalama.Tests.DotNetSdk",
165155
VcsProvider.GitHub,
@@ -168,7 +158,7 @@ public MetalamaDependencyDefinition(
168158
parentCiProjectId: $"Metalama_Metalama{Family.VersionWithoutDots}_MetalamaTests",
169159
vcsRootProjectId: $"Metalama_Metalama{Family.VersionWithoutDots}" );
170160

171-
public static DependencyDefinition MetalamaPerformance { get; } =
161+
public static DependencyDefinition MetalamaPerformance { get; } =
172162
new MetalamaDependencyDefinition(
173163
"Metalama.Performance",
174164
VcsProvider.GitHub,

src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/TemplateDependencies.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public TemplateDependencyDefinition(
2727
isVersioned ) { }
2828
}
2929

30-
public static ProductFamily Family { get; } = new( "Template", "2023.0", DevelopmentDependencies.Family, MetalamaDependencies.V2024_2.Family );
30+
public static ProductFamily Family { get; } = new( "Template", "2023.0", DevelopmentDependencies.Family, MetalamaDependencies.V2025_1.Family );
3131

3232
// This is only used from the project template.
3333
public static DependencyDefinition MyProduct { get; } =

0 commit comments

Comments
 (0)