Warnings, formatting.

Author: gfraiteur

src/PostSharp.Engineering.BuildTools/BillOfMaterials/DependencyWalker.cs

@@ -221,7 +221,7 @@ private static async Task<IReadOnlyCollection<PackageInfo>> GetPackageInfoAsync(
             {
                 ApplyPackageOverrides( context, packageName, packageVersionInfo, ref usageKind );
 
-                packageVersionInfo!.Usage.Add( usageKind );
+                packageVersionInfo.Usage.Add( usageKind );
 
                 if ( usageKind != DependentPackageUsageKind.Private )
                 {

src/PostSharp.Engineering.BuildTools/BillOfMaterials/GenerateThirdPartyNoticesCommand.cs

@@ -85,9 +85,9 @@ This file is semi-automatically generated by the `Build.ps1 third-party-notice`
         writer.WriteLine( "| Namespace | Justification |" );
         writer.WriteLine( "|-----------|---------------|" );
 
-        foreach ( var exclusion in (DependencyWalker.DefaultDependentPackageExclusions
+        foreach ( var exclusion in DependencyWalker.DefaultDependentPackageExclusions
                      .Concat( context.Product.DependentPackageExclusions )
-                     .OrderBy( x => x.Namespace )) )
+                     .OrderBy( x => x.Namespace ) )
 
         {
             writer.WriteLine( $"| {exclusion.Namespace.TrimEnd( '.' )} | {exclusion.Justification} |" );

src/PostSharp.Engineering.BuildTools/Build/BuildConfigurationInfo.cs

@@ -1,6 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using PostSharp.Engineering.BuildTools.Build.Model;
 using PostSharp.Engineering.BuildTools.Build.Publishing;
 using PostSharp.Engineering.BuildTools.Build.Swapping;
 using PostSharp.Engineering.BuildTools.Build.Triggers;

src/PostSharp.Engineering.BuildTools/Build/BuildContext.cs

@@ -2,7 +2,6 @@
 
 using JetBrains.Annotations;
 using PostSharp.Engineering.BuildTools.Build.Model;
-using PostSharp.Engineering.BuildTools.ContinuousIntegration;
 using PostSharp.Engineering.BuildTools.Tools.TeamCity;
 using PostSharp.Engineering.BuildTools.Utilities;
 using Spectre.Console.Cli;

src/PostSharp.Engineering.BuildTools/Build/CleanCommand.cs

@@ -1,8 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using PostSharp.Engineering.BuildTools.Build.Model;
-using PostSharp.Engineering.BuildTools.ContinuousIntegration;
-using PostSharp.Engineering.BuildTools.Tools.TeamCity;
 using PostSharp.Engineering.BuildTools.Utilities;
 using System;
 using System.IO;

src/PostSharp.Engineering.BuildTools/Build/Files/MasterGenerator.cs

@@ -1,6 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using PostSharp.Engineering.BuildTools.Build.Model;
 using PostSharp.Engineering.BuildTools.Dependencies.Model;
 using PostSharp.Engineering.BuildTools.Utilities;
 using System.Diagnostics.CodeAnalysis;

src/PostSharp.Engineering.BuildTools/Build/Files/NuGetConfigFile.cs

@@ -1,6 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using PostSharp.Engineering.BuildTools.Build.Model;
 using PostSharp.Engineering.BuildTools.Dependencies.Model;
 using PostSharp.Engineering.BuildTools.Utilities;
 using System;
@@ -18,7 +17,6 @@ internal static class NuGetConfigFile
     internal static bool TryWrite( BuildContext context, DependenciesConfigurationFile dependenciesConfigurationFile, BuildConfiguration configuration )
     {
         var product = context.Product;
-        var console = context.Console;
 
         if ( !product.GenerateNuGetConfig )
         {

src/PostSharp.Engineering.BuildTools/Build/Files/TeamCitySettingsFile.cs

@@ -1,6 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using PostSharp.Engineering.BuildTools.Build.Model;
 using PostSharp.Engineering.BuildTools.Build.Triggers;
 using PostSharp.Engineering.BuildTools.ContinuousIntegration.Model;
 using PostSharp.Engineering.BuildTools.ContinuousIntegration.Model.BuildSteps;

src/PostSharp.Engineering.BuildTools/Build/Helpers/GitIntegrationHelper.cs

@@ -3,7 +3,6 @@
 using PostSharp.Engineering.BuildTools.Build.Files;
 using PostSharp.Engineering.BuildTools.Build.Model;
 using PostSharp.Engineering.BuildTools.Build.Publishing;
-using PostSharp.Engineering.BuildTools.ContinuousIntegration;
 using PostSharp.Engineering.BuildTools.Tools.TeamCity;
 using PostSharp.Engineering.BuildTools.Utilities;
 using System;

src/PostSharp.Engineering.BuildTools/Build/Model/BuildMethod.cs

@@ -3,7 +3,7 @@
 namespace PostSharp.Engineering.BuildTools.Build.Model
 {
     /// <summary>
-    /// Enumerates the method that determines what <see cref="BuildCommand"/> or <see cref="Product.Build"/>
+    /// Enumerates the method that determines what <see cref="BuildCommand"/>
     /// should do. This property is exposed by <see cref="Solution"/>.
     /// </summary>
     public enum BuildMethod