Fixing issues on Ubuntu and with .NET 9.

Author: gfraiteur

src/PostSharp.Engineering.BuildTools/BaseCommand.cs

@@ -41,8 +41,6 @@ public sealed override int Execute( CommandContext context, T settings )
                     buildContext = buildContext.WithUseProjectDirectoryAsWorkingDirectory( true );
                 }
 
-                MSBuildHelper.InitializeLocator();
-
                 if ( DockerHelper.IsDockerBuild() )
                 {
                     buildContext.Console.WriteMessage( "Docker detected." );

src/PostSharp.Engineering.BuildTools/MSBuildHelper.cs

@@ -1,4 +1,6 @@
-using Microsoft.Build.Locator;
+// Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
+
+using Microsoft.Build.Locator;
 using Microsoft.VisualStudio.Setup.Configuration;
 using System;
 using System.Collections.Generic;
@@ -18,17 +20,17 @@ internal static class MSBuildHelper
 
     public static void InitializeLocator()
     {
-        if (!_isInitialized)
+        if ( !_isInitialized )
         {
-            if (MSBuildLocator.CanRegister)
+            if ( MSBuildLocator.CanRegister )
             {
                 try
                 {
                     MSBuildLocator.RegisterDefaults();
 
                     _isInitialized = true;
                 }
-                catch (Exception e)
+                catch ( Exception e )
                 {
                     throw new InvalidOperationException(
                         $"Cannot find a suitable version of MSBuild for "
@@ -45,7 +47,7 @@ public static void InitializeLocator()
     {
         var directory = FindLatestMSBuildDirectory( context );
 
-        if (directory == null)
+        if ( directory == null )
         {
             return directory;
         }
@@ -57,14 +59,16 @@ public static void InitializeLocator()
 
     private static string? FindLatestMSBuildDirectory( BuildContext context )
     {
+        InitializeLocator();
+
         var instances = GetVisualStudioInstances( context ).OrderByDescending( i => i.Version );
 
-        foreach (var instance in instances)
+        foreach ( var instance in instances )
         {
             // We got a Visual Studio instance but not all of them have an MSBuild instance. For instance, a Test Agent instance does not have.
             var directory = Path.Combine( instance.Path, "MSBuild", "Current", "Bin" );
 
-            if (Directory.Exists( directory ))
+            if ( Directory.Exists( directory ) )
             {
                 return directory;
             }
@@ -75,7 +79,9 @@ public static void InitializeLocator()
 
     public static IEnumerable<VisualStudioInstance> GetVisualStudioInstances( BuildContext context )
     {
-        if (!RuntimeInformation.IsOSPlatform( OSPlatform.Windows ))
+        InitializeLocator();
+
+        if ( !RuntimeInformation.IsOSPlatform( OSPlatform.Windows ) )
         {
             return [];
         }
@@ -95,9 +101,9 @@ public static IEnumerable<VisualStudioInstance> GetVisualStudioInstances( BuildC
             {
                 enumInstances.Next( 1, instances, out fetched );
 
-                if (fetched > 0)
+                if ( fetched > 0 )
                 {
-                    var instance = (ISetupInstance2)instances[0];
+                    var instance = (ISetupInstance2) instances[0];
 
                     list.Add(
                         new VisualStudioInstance(
@@ -106,9 +112,9 @@ public static IEnumerable<VisualStudioInstance> GetVisualStudioInstances( BuildC
                             instance.GetInstallationPath() ) );
                 }
             }
-            while (fetched > 0);
+            while ( fetched > 0 );
         }
-        catch (COMException exception)
+        catch ( COMException exception )
         {
             context.Console.WriteWarning( $"Cannot find VS instances: {exception.Message}" );
 

src/PostSharp.Engineering.BuildTools/Utilities/ToolInvocationHelper.cs

@@ -374,7 +374,18 @@ void FilterProcessOutput( string output )
                             using ( ManualResetEvent exitedEvent = new( false ) )
                             {
                                 process.EnableRaisingEvents = true;
-                                process.Exited += ( _, _ ) => exitedEvent.Set();
+
+                                process.Exited += ( _, _ ) =>
+                                {
+                                    try
+                                    {
+                                        exitedEvent.Set();
+                                    }
+                                    catch ( ObjectDisposedException )
+                                    {
+                                        // This happens on Ubuntu.
+                                    }
+                                };
 
                                 using ( cancellationToken.Register( () => cancelledEvent.Set() ) )
                                 {