Added back ability for PrivateArtifactDirectory to contain a parameter.

gfraiteur · gfraiteur · commit e55b3fb2f61a · 2025-09-25T12:33:02.000+02:00
diff --git a/src/PostSharp.Engineering.BuildTools/Build/BuildCommand.cs b/src/PostSharp.Engineering.BuildTools/Build/BuildCommand.cs
@@ -127,7 +127,7 @@ public static bool Execute( BuildContext context, BuildSettings settings )
             // We have to read the version from the file we have generated - using MSBuild, because it contains properties.
             var buildInfo = BuildArguments.Read( context, settings.BuildConfiguration );
 
-            var privateArtifactsDirectory = product.GetPrivateArtifactsDirectory( context );
+            var privateArtifactsDirectory = product.GetPrivateArtifactsDirectory( settings.BuildConfiguration );
 
             // Build solutions.
             IEnumerable<Solution> solutionsToBuild;
diff --git a/src/PostSharp.Engineering.BuildTools/Build/BuildContext.cs b/src/PostSharp.Engineering.BuildTools/Build/BuildContext.cs
@@ -60,10 +60,10 @@ public static bool IsGuestDevice
         /// Gets the full path of the current manifest file (i.e. the file called <c>My.Product.version.props</c>)
         /// for a given <see cref="BuildConfiguration"/>.
         /// </summary>
-        public string ManifestFilePath
+        public string GetManifestFilePath( BuildConfiguration configuration )
             => Path.Combine(
                 this.RepoDirectory,
-                this.Product.PrivateArtifactsDirectory,
+                this.Product.GetPrivateArtifactsDirectory( configuration ),
                 $"{this.Product.ProductName}.version.props" );
 
         private BuildContext(
diff --git a/src/PostSharp.Engineering.BuildTools/Build/CleanCommand.cs b/src/PostSharp.Engineering.BuildTools/Build/CleanCommand.cs
@@ -116,12 +116,10 @@ void CleanNugetCache()
                 DeleteDirectory( Path.Combine( context.RepoDirectory, directory ) );
             }
 
-            var stringParameters = new BuildArguments( null, settings.BuildConfiguration, product, null );
-
             DeleteDirectory(
                 Path.Combine(
                     context.RepoDirectory,
-                    product.PrivateArtifactsDirectory ) );
+                    product.GetPrivateArtifactsDirectory( settings.BuildConfiguration ) ) );
 
             DeleteDirectory(
                 Path.Combine(
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Files/ArtifactManifestFile.cs b/src/PostSharp.Engineering.BuildTools/Build/Files/ArtifactManifestFile.cs
@@ -99,7 +99,7 @@ void AppendToArcadeSuffix( string s )
         <{product.ProductNameWithoutDot}BuildConfiguration>{configuration}</{product.ProductNameWithoutDot}BuildConfiguration>
         <{product.ProductNameWithoutDot}Dependencies>{string.Join( ";", product.ParametrizedDependencies.Select( x => x.Name ) )}</{product.ProductNameWithoutDot}Dependencies>
         <{product.ProductNameWithoutDot}PublicArtifactsDirectory>{product.PublicArtifactsDirectory}</{product.ProductNameWithoutDot}PublicArtifactsDirectory>
-        <{product.ProductNameWithoutDot}PrivateArtifactsDirectory>{product.PrivateArtifactsDirectory}</{product.ProductNameWithoutDot}PrivateArtifactsDirectory>
+        <{product.ProductNameWithoutDot}PrivateArtifactsDirectory>{product.GetPrivateArtifactsDirectory( configuration )}</{product.ProductNameWithoutDot}PrivateArtifactsDirectory>
         <{product.ProductNameWithoutDot}EngineeringVersion>{VersionHelper.EngineeringVersion}</{product.ProductNameWithoutDot}EngineeringVersion>
         <{product.ProductNameWithoutDot}VersionFilePath>{product.VersionsFilePath}</{product.ProductNameWithoutDot}VersionFilePath>
         <{product.ProductNameWithoutDot}BuildNumber>{buildSettings.BuildNumber}</{product.ProductNameWithoutDot}BuildNumber>
@@ -206,7 +206,7 @@ internal static string GetPath( BuildContext context, BuildConfiguration configu
     {
         var product = context.Product;
 
-        var privateArtifactsRelativeDir = product.PrivateArtifactsDirectory;
+        var privateArtifactsRelativeDir = product.GetPrivateArtifactsDirectory( configuration );
 
         var artifactsDir = Path.Combine( context.RepoDirectory, privateArtifactsRelativeDir );
 
@@ -225,7 +225,7 @@ public static bool TryRead(
         [NotNullWhen( true )] out ArtifactManifestVersionInfo? artifactManifestVersionInfo )
     {
         var product = context.Product;
-        var artifactVersionFile = context.ManifestFilePath;
+        var artifactVersionFile = context.GetManifestFilePath( configuration );
 
         var document = XDocument.Load( artifactVersionFile );
         var project = document.Root;
@@ -264,7 +264,7 @@ public static bool TryRead(
     public static BuildArguments CreateParametricStringArguments( BuildContext context, BuildConfiguration buildConfiguration )
     {
         var product = context.Product;
-        var versionFilePath = context.ManifestFilePath;
+        var versionFilePath = context.GetManifestFilePath( buildConfiguration );
 
         if ( !File.Exists( versionFilePath ) )
         {
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Files/ImportFile.cs b/src/PostSharp.Engineering.BuildTools/Build/Files/ImportFile.cs
@@ -27,7 +27,7 @@ public static void Write( BuildContext context, BuildConfiguration configuration
         var product = context.Product;
 
         // Write a link to this file in the root file of the repo. This file is the interface of the repo, which can be imported by other repos.
-        var manifestFilePath = context.ManifestFilePath;
+        var manifestFilePath = context.GetManifestFilePath( configuration );
         var importFilePath = Path.Combine( context.RepoDirectory, product.ProductName + ".Import.props" );
 
         // We're generating a relative path so that the path can be resolved even when the filesystem is mounted
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Files/NuGetConfigFile.cs b/src/PostSharp.Engineering.BuildTools/Build/Files/NuGetConfigFile.cs
@@ -81,7 +81,7 @@ internal static bool TryWrite( BuildContext context, DependenciesConfigurationFi
         // Add the current artifact directory.
         var artifactDirectory = Path.Combine(
             context.RepoDirectory,
-            product.PrivateArtifactsDirectory );
+            product.GetPrivateArtifactsDirectory( configuration ) );
 
         AddDirectory( product.ProductName, artifactDirectory, product.DependencyDefinition.PackagePatterns );
 
@@ -119,7 +119,7 @@ internal static bool TryWrite( BuildContext context, DependenciesConfigurationFi
 
                 dependencyDirectory = Path.Combine(
                     dependencyDirectory,
-                    dependencyDefinition.PrivateArtifactsDirectory );
+                    dependencyDefinition.GetPrivateArtifactsDirectory( configuration ) );
             }
 
             if ( !AddDirectory( dependencySource.Key, dependencyDirectory, dependencyDefinition.PackagePatterns ) )
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Files/TeamCitySettingsFile.cs b/src/PostSharp.Engineering.BuildTools/Build/Files/TeamCitySettingsFile.cs
@@ -53,7 +53,7 @@ private static bool TryWriteStandalone( BuildContext context, CommonCommandSetti
                 context.Product.PublicArtifactsDirectory.Replace( "\\", "/", StringComparison.Ordinal );
 
             var privateArtifactsDirectory =
-                context.Product.PrivateArtifactsDirectory.Replace( "\\", "/", StringComparison.Ordinal );
+                context.Product.GetPrivateArtifactsDirectory( configuration ).Replace( "\\", "/", StringComparison.Ordinal );
 
             var testResultsDirectory =
                 context.Product.TestResultsDirectory.Replace( "\\", "/", StringComparison.Ordinal );
@@ -98,7 +98,7 @@ private static bool TryWriteStandalone( BuildContext context, CommonCommandSetti
                 .Select( d => new TeamCitySnapshotDependency(
                              d.Definition.CiConfiguration.BuildTypes[d.Configuration],
                              true,
-                             $"+:{d.Definition.PrivateArtifactsDirectory.Replace( Path.DirectorySeparatorChar, '/' )}/**/*=>dependencies/{d.Name}" ) )
+                             $"+:{d.Definition.GetPrivateArtifactsDirectory( d.Configuration ).Replace( Path.DirectorySeparatorChar, '/' )}/**/*=>dependencies/{d.Name}" ) )
                 .ToList();
 
             var sourceSnapshotDependencies = product.SourceDependencies.Where( d => d.GenerateSnapshotDependency )
@@ -468,9 +468,7 @@ bool TryPopulateBuildConfigurations(
                 if ( dependencyDefinition.ProductFamily == product.ProductFamily
                      && !projectsWithNoNuGetArtifacts.Any( p => dependencyDefinition.Name.Contains( p, StringComparison.Ordinal ) ) )
                 {
-                    var dependencyMsBuildConfiguration = dependencyDefinition.MSBuildConfiguration[configuration];
-
-                    var dependencyPrivateArtifactsDirectory = dependencyDefinition.PrivateArtifactsDirectory
+                    var dependencyPrivateArtifactsDirectory = dependencyDefinition.GetPrivateArtifactsDirectory( configuration )
                         .Replace( Path.DirectorySeparatorChar, '/' );
 
                     var dependencyPublicArtifactsDirectory = dependencyDefinition.PublicArtifactsDirectory
@@ -520,10 +518,8 @@ bool TryPopulateBuildConfigurations(
                         .Select( c => c! ) );
             }
 
-            var buildInfo = new BuildArguments( null, configuration, product, null );
-
             var privateArtifactsDirectory =
-                product.PrivateArtifactsDirectory.Replace( "\\", "/", StringComparison.Ordinal );
+                product.GetPrivateArtifactsDirectory( configuration ).Replace( "\\", "/", StringComparison.Ordinal );
 
             var publicArtifactsDirectory =
                 product.PublicArtifactsDirectory.Replace( "\\", "/", StringComparison.Ordinal );
@@ -845,7 +841,7 @@ bool TryAddPreOrPostDeploymentBuildConfiguration(
                         {
                             var dependencyName = dependencyDefinition.Name;
 
-                            var dependencyPrivateArtifactsDirectory = dependencyDefinition.PrivateArtifactsDirectory
+                            var dependencyPrivateArtifactsDirectory = dependencyDefinition.GetPrivateArtifactsDirectory( BuildConfiguration.Public )
                                 .Replace( Path.DirectorySeparatorChar, '/' );
 
                             var artifactRules =
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Model/Pattern.cs b/src/PostSharp.Engineering.BuildTools/Build/Model/Pattern.cs
@@ -60,6 +60,7 @@ private Pattern( ImmutableArray<(ParametricString Pattern, bool IsExclude)> item
         public bool Verify( BuildContext context, string directory, BuildArguments buildArguments )
         {
             var success = true;
+            var absoluteDirectory = Path.Combine( context.RepoDirectory, directory );
 
             foreach ( var pattern in this.Items )
             {
@@ -73,11 +74,11 @@ public bool Verify( BuildContext context, string directory, BuildArguments build
                 matcher.AddInclude( expandedPattern );
 
                 var matchingResult =
-                    matcher.Execute( new DirectoryInfoWrapper( new DirectoryInfo( directory ) ) );
+                    matcher.Execute( new DirectoryInfoWrapper( new DirectoryInfo( absoluteDirectory ) ) );
 
                 if ( !matchingResult.HasMatches )
                 {
-                    context.Console.WriteError( $"The pattern '{directory}\\{expandedPattern}' does not match any file." );
+                    context.Console.WriteError( $"The pattern '{absoluteDirectory}\\{expandedPattern}' does not match any file." );
                     success = false;
                 }
             }
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Model/Product.cs b/src/PostSharp.Engineering.BuildTools/Build/Model/Product.cs
@@ -79,8 +79,12 @@ public string BumpInfoFilePath
 
         public string ProductNameWithoutDot => this.ProductName.Replace( ".", "", StringComparison.OrdinalIgnoreCase );
 
+        [Obsolete( "Use GetPrivateArtifactsDirectory." )]
         public string PrivateArtifactsDirectory => this.DependencyDefinition.PrivateArtifactsDirectory;
 
+        public string GetPrivateArtifactsDirectory( BuildConfiguration configuration )
+            => this.DependencyDefinition.GetPrivateArtifactsDirectory( configuration );
+
         public string PublicArtifactsDirectory => this.DependencyDefinition.PublicArtifactsDirectory;
 
         public string TestResultsDirectory { get; init; } = Path.Combine( "artifacts", "testResults" );
@@ -294,10 +298,10 @@ public bool TryGetDependencyDefinition( string name, [NotNullWhen( true )] out D
 
         public bool IsBundle { get; init; }
 
-        internal string GetPrivateArtifactsDirectory( BuildContext context )
+        internal string GetPrivateArtifactsDirectory( BuildContext context, BuildConfiguration configuration )
             => Path.Combine(
                 context.RepoDirectory,
-                this.PrivateArtifactsDirectory );
+                this.GetPrivateArtifactsDirectory( configuration ) );
 
         internal string GetPublicArtifactsDirectory( BuildContext context )
             => Path.Combine(
@@ -335,10 +339,10 @@ internal void OnPrepareCompleted( PrepareCompletedEventArgs args )
             this.PrepareCompleted?.Invoke( args );
         }
 
-        internal (string Private, string Public) GetArtifactsDirectories( BuildContext context )
+        internal (string Private, string Public) GetArtifactsDirectories( BuildContext context, BuildConfiguration configuration )
         {
             return (
-                Path.Combine( context.RepoDirectory, this.PrivateArtifactsDirectory ),
+                Path.Combine( context.RepoDirectory, this.GetPrivateArtifactsDirectory( configuration ) ),
                 Path.Combine( context.RepoDirectory, this.PublicArtifactsDirectory )
             );
         }
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Publishing/PublishCommand.cs b/src/PostSharp.Engineering.BuildTools/Build/Publishing/PublishCommand.cs
@@ -119,7 +119,7 @@ public static bool Execute( BuildContext context, PublishSettings settings )
 
         var configuration = settings.BuildConfiguration;
         var buildArguments = BuildArguments.Read( context, configuration );
-        var directories = product.GetArtifactsDirectories( context );
+        var directories = product.GetArtifactsDirectories( context, configuration );
         var configurationInfo = product.Configurations.GetValue( configuration );
         var hasTarget = false;
 
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Swapping/SwapCommand.cs b/src/PostSharp.Engineering.BuildTools/Build/Swapping/SwapCommand.cs
@@ -28,7 +28,7 @@ private static bool Execute( BuildContext context, SwapSettings settings )
         var product = context.Product;
         var configuration = product.Configurations.GetValue( settings.BuildConfiguration );
         var buildArguments = BuildArguments.Read( context, settings.BuildConfiguration );
-        var directories = product.GetArtifactsDirectories( context );
+        var directories = product.GetArtifactsDirectories( context, settings.BuildConfiguration );
 
         var success = true;
 
diff --git a/src/PostSharp.Engineering.BuildTools/Build/Testing/TestCommand.cs b/src/PostSharp.Engineering.BuildTools/Build/Testing/TestCommand.cs
@@ -112,7 +112,7 @@ public static bool Execute( BuildContext context, BuildSettings settings )
 
         // Raise the post-test event.
         var buildInfo = BuildArguments.Read( context, settings.BuildConfiguration );
-        var privateArtifactsDirectory = product.GetPrivateArtifactsDirectory( context );
+        var privateArtifactsDirectory = product.GetPrivateArtifactsDirectory( context, settings.BuildConfiguration );
         var publicArtifactsDirectory = product.GetPublicArtifactsDirectory( context );
 
         var eventArgs = new BuildCompletedEventArgs( context, settings, buildInfo, privateArtifactsDirectory, publicArtifactsDirectory );
diff --git a/src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2025_0.cs b/src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2025_0.cs
@@ -83,7 +83,9 @@ public MetalamaDependencyDefinition(
                 MetalamaGitHubOrganization.Metalama )
             {
                 EngineeringDirectory = "eng-Metalama",
-                PrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSBuildConfiguration)", "Shipping" )
+#pragma warning disable CS0618 // Type or member is obsolete
+                ParametricPrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSBuildConfiguration)", "Shipping" )
+#pragma warning restore CS0618 // Type or member is obsolete
             };
 
         public static DependencyDefinition MetalamaFrameworkRunTime { get; } =
diff --git a/src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2025_1.cs b/src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2025_1.cs
@@ -76,7 +76,9 @@ public MetalamaDependencyDefinition(
                 MetalamaGitHubOrganization.Metalama )
             {
                 EngineeringDirectory = "eng-Metalama",
-                PrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSBuildConfiguration)", "Shipping" )
+#pragma warning disable CS0618 // Type or member is obsolete
+                ParametricPrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSBuildConfiguration)", "Shipping" )
+#pragma warning restore CS0618 // Type or member is obsolete
             };
 
         public static DependencyDefinition Metalama { get; } =
diff --git a/src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2025_2.cs b/src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2025_2.cs
@@ -75,7 +75,10 @@ public MetalamaDependencyDefinition(
                 MetalamaGitHubOrganization.Metalama )
             {
                 EngineeringDirectory = "eng-Metalama",
-                PrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSBuildConfiguration)", "Shipping" )
+#pragma warning disable CS0618 // Type or member is obsolete
+                ParametricPrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSBuildConfiguration)", "Shipping" )
+#pragma warning restore CS0618 // Type or member is obsolete
+
             };
 
         public static DependencyDefinition Metalama { get; } =
diff --git a/src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2026_0.cs b/src/PostSharp.Engineering.BuildTools/Dependencies/Definitions/MetalamaDependencies.V2026_0.cs
@@ -77,7 +77,9 @@ public MetalamaDependencyDefinition(
                 MetalamaGitHubOrganization.Metalama )
             {
                 EngineeringDirectory = "eng-Metalama",
-                PrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSBuildConfiguration)", "Shipping" )
+#pragma warning disable CS0618 // Type or member is obsolete
+                ParametricPrivateArtifactsDirectory = Path.Combine( "artifacts", "packages", "$(MSBuildConfiguration)", "Shipping" )
+#pragma warning restore CS0618 // Type or member is obsolete
             };
 
         public static DependencyDefinition Metalama { get; } =
diff --git a/src/PostSharp.Engineering.BuildTools/Dependencies/DependenciesHelper.cs b/src/PostSharp.Engineering.BuildTools/Dependencies/DependenciesHelper.cs
@@ -80,7 +80,7 @@ public static bool UpdateOrFetchDependencies(
             }
 
             // Download build server dependencies.
-            if ( tc != null && !DownloadArtifacts( context, tc, iterationDependencies ) )
+            if ( tc != null && !DownloadArtifacts( context, tc, iterationDependencies, configuration ) )
             {
                 return false;
             }
@@ -384,7 +384,8 @@ private static bool ResolveBuildNumbersFromBranches(
     private static bool DownloadArtifacts(
         BuildContext context,
         TeamCityClient teamCity,
-        ImmutableDictionary<string, ResolvedDependency> dependencies )
+        ImmutableDictionary<string, ResolvedDependency> dependencies,
+        BuildConfiguration configuration )
     {
         foreach ( var dependency in dependencies.Values )
         {
@@ -421,7 +422,7 @@ private static bool DownloadArtifacts(
                 return false;
             }
 
-            var artifactsDirectory = dependency.Dependency.PrivateArtifactsDirectory;
+            var artifactsDirectory = dependency.Dependency.GetPrivateArtifactsDirectory( configuration );
 
             if ( !DownloadDependency(
                     context,
diff --git a/src/PostSharp.Engineering.BuildTools/Dependencies/Model/DependencyDefinition.cs b/src/PostSharp.Engineering.BuildTools/Dependencies/Model/DependencyDefinition.cs
@@ -61,7 +61,21 @@ public class DependencyDefinition
 
         public VcsRepository VcsRepository { get; }
 
-        public string PrivateArtifactsDirectory { get; init; } = Path.Combine( "artifacts", "publish", "private" );
+        public string PrivateArtifactsDirectory
+        {
+            [Obsolete( "Use GetPrivateArtifactsDirectory." )]
+            get;
+            init;
+        } = Path.Combine( "artifacts", "publish", "private" );
+
+        [Obsolete( "This property should not be used except for Metalama.Compiler, for historical reasons. Use PrivateArtifactsDirectory." )]
+        public ParametricString ParametricPrivateArtifactsDirectory { get; init; } = Path.Combine( "artifacts", "publish", "private" );
+
+        // Metalama.Compiler uses a placeholder for the MSBuild configuration.
+        public string GetPrivateArtifactsDirectory( BuildConfiguration configuration )
+#pragma warning disable CS0618 // Type or member is obsolete
+            => this.ParametricPrivateArtifactsDirectory.ToString( new BuildArguments() { MSBuildConfiguration = this.MSBuildConfiguration[configuration] } );
+#pragma warning restore CS0618 // Type or member is obsolete
 
         public string PublicArtifactsDirectory { get; init; } = Path.Combine( "artifacts", "publish", "public" );
 
diff --git a/src/PostSharp.Engineering.BuildTools/Tools/VerifyCommand.cs b/src/PostSharp.Engineering.BuildTools/Tools/VerifyCommand.cs
@@ -22,7 +22,7 @@ public static bool Execute( BuildContext context, PublishSettings settings )
         if ( configuration == BuildConfiguration.Public )
         {
             var buildArguments = BuildArguments.Read( context, configuration );
-            var directories = product.GetArtifactsDirectories( context );
+            var directories = product.GetArtifactsDirectories( context, configuration );
 
             // Verify that public packages have no private dependencies.
             if ( !VerifyPublicPackageCommand.Execute(

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ private Pattern( ImmutableArray<(ParametricString Pattern, bool IsExclude)> item`
`60`	`60`	`public bool Verify( BuildContext context, string directory, BuildArguments buildArguments )`
`61`	`61`	`{`
`62`	`62`	`var success = true;`
	`63`	`+ var absoluteDirectory = Path.Combine( context.RepoDirectory, directory );`
`63`	`64`
`64`	`65`	`foreach ( var pattern in this.Items )`
`65`	`66`	`{`
`@@ -73,11 +74,11 @@ public bool Verify( BuildContext context, string directory, BuildArguments build`
`73`	`74`	`matcher.AddInclude( expandedPattern );`
`74`	`75`
`75`	`76`	`var matchingResult =`
`76`		`- matcher.Execute( new DirectoryInfoWrapper( new DirectoryInfo( directory ) ) );`
	`77`	`+ matcher.Execute( new DirectoryInfoWrapper( new DirectoryInfo( absoluteDirectory ) ) );`
`77`	`78`
`78`	`79`	`if ( !matchingResult.HasMatches )`
`79`	`80`	`{`
`80`		`- context.Console.WriteError( $"The pattern '{directory}\\{expandedPattern}' does not match any file." );`
	`81`	`+ context.Console.WriteError( $"The pattern '{absoluteDirectory}\\{expandedPattern}' does not match any file." );`
`81`	`82`	`success = false;`
`82`	`83`	`}`
`83`	`84`	`}`