Push on bump.

Author: gfraiteur

src/PostSharp.Engineering.BuildTools/Build/Bumping/BumpCommand.cs

@@ -174,6 +174,15 @@ public static bool Execute( BuildContext context, BumpSettings settings )
             return false;
         }
 
+        // If we are running in TeamCity, push.
+        if ( context.IsContinuousIntegrationBuild )
+        {
+            if ( !GitHelper.TryPush( context ) )
+            {
+                return false;
+            }
+        }
+
         return true;
     }
 

src/PostSharp.Engineering.BuildTools/Tools/Git/DownstreamMerge.cs

@@ -306,7 +306,7 @@ public static bool MergeDownstream( BuildContext context, DownstreamMergeSetting
         // Push the branch now to avoid issues when the DownstreamMergeCommand
         // is executed again with the same upstream changes
         // or when developers are required to resolve conflicts.
-        if ( !GitHelper.TryPush( context, settings ) )
+        if ( !GitHelper.TryPush( context ) )
         {
             return false;
         }
@@ -428,7 +428,7 @@ void AddFileToKeepOwn( string path )
         }
 
         // We push even if there's nothing to merge as there could be commits from manual conflict resolution.
-        if ( !GitHelper.TryPush( context, settings ) )
+        if ( !GitHelper.TryPush( context ) )
         {
             areChangesPending = false;
 

src/PostSharp.Engineering.BuildTools/Utilities/GitHelper.cs

@@ -105,7 +105,7 @@ public static bool TryPullAndMergeAndPush( BuildContext context, BuildSettings s
         }
 
         // Push the target branch.
-        if ( !TryPush( context, settings ) )
+        if ( !TryPush( context ) )
         {
             return false;
         }
@@ -292,7 +292,7 @@ public static bool TryGetRemoteReferences(
     {
         references = null;
 
-        if ( !TryGetOriginUrl( context, settings, out var originUrl ) )
+        if ( !TryGetOriginUrl( context, out var originUrl ) )
         {
             return false;
         }
@@ -432,7 +432,7 @@ public static bool TryResolveUsingOurs( BuildContext context, string file )
         return true;
     }
 
-    private static bool TryGetOriginUrl( BuildContext context, BaseBuildSettings settings, [NotNullWhen( true )] out string? url )
+    private static bool TryGetOriginUrl( BuildContext context, [NotNullWhen( true )] out string? url )
     {
         url = null;
 
@@ -456,7 +456,7 @@ private static bool TryGetOriginUrl( BuildContext context, BaseBuildSettings set
         var isHttps = url.StartsWith( "https", StringComparison.InvariantCulture );
 
         // When on TeamCity, origin will be updated to form including Git authentication credentials.
-        if ( isHttps && TeamCityHelper.IsTeamCityBuild( settings ) )
+        if ( isHttps && context.IsContinuousIntegrationBuild )
         {
             if ( !TeamCityHelper.TryGetTeamCitySourceWriteToken(
                     out var teamcitySourceWriteTokenEnvironmentVariableName,
@@ -474,9 +474,9 @@ private static bool TryGetOriginUrl( BuildContext context, BaseBuildSettings set
         return true;
     }
 
-    public static bool TryPush( BuildContext context, BaseBuildSettings settings )
+    public static bool TryPush( BuildContext context )
     {
-        if ( !TryGetOriginUrl( context, settings, out var originUrl ) )
+        if ( !TryGetOriginUrl( context, out var originUrl ) )
         {
             return false;
         }
@@ -627,7 +627,7 @@ public static bool ConfigureAuthentication( BuildContext context )
     {
         var console = context.Console;
         var environmentVariable = context.Product.DependencyDefinition.VcsRepository.TokenEnvironmentVariableName;
-        
+
         console.WriteMessage( "Configuring git credentials." );
 
         if ( RuntimeInformation.IsOSPlatform( OSPlatform.Windows ) )