Show error only after all retries failed (@pinia/colada-plugin-retry)

[andre8244]

@pinia/colada-plugin-retry is very useful, but I wonder if there is a way to show the error only after all retries have failed.
It would be very useful in case of temporary network failures.

For example, Tanstack query sets the error variable only after all retries failed: https://tanstack.com/query/latest/docs/framework/vue/guides/query-retries

Is this behavior already supported by pinia-colada?

[posva]

I think that the plugin could evolve a bit:

• Move the error to a different property maybe (retryError)
• Return the amount of retries from useQuery retryCount
• Return if it's retrying (only true after one error) isRetrying

The delay plugin adds extra stuff (https://github.com/posva/pinia-colada/blob/main/plugins/delay/src/index.ts#L83) and the retry plugin should too

[posva]

Done in #509

[87xie]

This is helpful, and hope it also integrates well with other plugins like the following example:

queryCache.$onAction(({ name, onError }) => {
  if (name === 'fetch') {
    onError((error) => {
      // trigger a notification after all retries have finished
    })
  }
})

[posva]

I think that onError will trigger on each error, no matter the retry.

This makes me think that I should add the retrying context to the query entries themselves. This ways they get automatically gced and can be read in actions like fetch to see if it's a retry or not

[87xie]

I agree that onError should trigger on every error, and being able to check the retrying context from the entry would help handle various scenarios.

[segevfiner]

I wanted to use this to retry network error transparently during dev, but since it returns the first error immediately instead of only the last error and it's not configurable, I'll just have to implement retries myself. Which defeats the purpose of the plugin...

[posva]

If you manage to add it to the plugin (see my comments above), I would love to add it to the plugin!