refactor: fix useless type ignore from mypy error + add ty type checker

Author: poupeaua

otary/geometry/discrete/point.py

@@ -3,7 +3,7 @@
 """
 
 import numpy as np
-from numpy.typing import NDArray
+from numpy.typing import NDArray, ArrayLike
 from shapely import Point as SPoint
 
 from otary.geometry.discrete.entity import DiscreteGeometryEntity
@@ -12,12 +12,12 @@
 class Point(DiscreteGeometryEntity):
     """Point class"""
 
-    def __init__(self, point: NDArray, is_cast_int: bool = False) -> None:
+    def __init__(self, point: ArrayLike, is_cast_int: bool = False) -> None:
         point = self._ensure_transform_point_array(point=point)
         super().__init__(points=point, is_cast_int=is_cast_int)
 
     @staticmethod
-    def _ensure_transform_point_array(point: NDArray) -> NDArray:
+    def _ensure_transform_point_array(point: ArrayLike) -> NDArray:
         point = np.asarray(point)
         if point.shape == (2,):
             point = point.reshape((1, 2))
@@ -58,7 +58,7 @@ def shapely_edges(self) -> SPoint:
         return SPoint(self.asarray)
 
     @property
-    def shapely_surface(self) -> SPoint:
+    def shapely_surface(self) -> None:
         """Returns None since a point has no surface
 
         Returns:

otary/image/components/drawer/drawer.py

@@ -50,18 +50,18 @@ def draw_circles(
         """
         im_array = self._pre_draw(n_objects=len(circles), render=render)
         for circle, color in zip(circles, render.colors_processed):
-            cv2.circle(  # type: ignore[call-overload]
+            cv2.circle(
                 img=im_array,
-                center=circle.center.astype(int),
+                center=tuple(circle.center.astype(int)),
                 radius=int(circle.radius),
                 color=color,
                 thickness=render.thickness if not render.is_filled else -1,
                 lineType=render.line_type,
             )
             if render.is_draw_center_point_enabled:
-                cv2.circle(  # type: ignore[call-overload]
+                cv2.circle(
                     img=im_array,
-                    center=circle.center.astype(int),
+                    center=tuple(circle.center.astype(int)),
                     radius=1,
                     color=color,
                     thickness=render.thickness,
@@ -83,9 +83,9 @@ def draw_ellipses(
         im_array = self._pre_draw(n_objects=len(ellipses), render=render)
         for ellipse, color in zip(ellipses, render.colors_processed):
             axes = (int(ellipse.semi_major_axis), int(ellipse.semi_minor_axis))
-            cv2.ellipse(  # type: ignore[call-overload]
+            cv2.ellipse(
                 img=im_array,
-                center=ellipse.centroid.astype(int),
+                center=tuple(ellipse.centroid.astype(int)),
                 axes=axes,
                 angle=ellipse.angle(degree=True),
                 startAngle=0,
@@ -95,19 +95,19 @@ def draw_ellipses(
                 lineType=render.line_type,
             )
             if render.is_draw_center_point_enabled:
-                cv2.circle(  # type: ignore[call-overload]
+                cv2.circle(
                     img=im_array,
-                    center=ellipse.centroid.astype(int),
+                    center=tuple(ellipse.centroid.astype(int)),
                     radius=1,
                     color=color,
                     thickness=render.thickness,
                     lineType=render.line_type,
                 )
             if render.is_draw_focis_enabled:
                 for foci in [ellipse.foci1, ellipse.foci2]:
-                    cv2.circle(  # type: ignore[call-overload]
+                    cv2.circle(
                         img=im_array,
-                        center=foci.astype(int),
+                        center=tuple(foci.astype(int)),
                         radius=1,
                         color=color,
                         thickness=render.thickness,

otary/image/components/drawer/utils/tools.py

@@ -25,9 +25,7 @@ def color_str_to_tuple(
         Optional[tuple]: color tuple or None if not possible
     """
     try:
-        color_tuple = ImageColor.getrgb(color_str)
-        if len(color_tuple) != 3:
-            raise ValueError
+        color_tuple = ImageColor.getrgb(color_str)[:3]  # in case of RGBA format
         if is_bgr:
             color_tuple = color_tuple[::-1]
     except ValueError:

otary/image/components/io/utils/readfile.py

@@ -35,6 +35,9 @@ def read_pdf_document(
             raise ValueError(f"The filepath is not in any valid format {valid_format}")
         pages = pymupdf.open(filename=filepath_or_stream)
 
+    # turns open document type into list of pages
+    pages = [pages[i] for i in range(len(pages))]
+
     # set pages if page_nb
     if page_nb is not None:
         if page_nb < 0:

otary/image/components/transformer/components/geometrizer/geometrizer.py

@@ -42,7 +42,7 @@ def shift(self, shift: NDArray, fill_value: Sequence[float] = (0.0,)) -> None:
             flags=cv2.INTER_LINEAR,
             borderMode=cv2.BORDER_CONSTANT,
             borderValue=fill_value,
-        )  # type: ignore[call-overload]
+        )
 
     def rotate(
         self,
@@ -106,7 +106,7 @@ def rotate(
             flags=cv2.INTER_LINEAR,
             borderMode=cv2.BORDER_CONSTANT,
             borderValue=fill_value,
-        )  # type: ignore[call-overload]
+        )
 
     def center_to_point(self, point: NDArray) -> NDArray:
         """Shift the image so that the input point ends up in the middle of the

otary/image/components/transformer/components/morphologyzer/morphologyzer.py

@@ -232,7 +232,7 @@ def add_border(self, size: int, fill_value: int = 0) -> None:
             right=size,
             borderType=cv2.BORDER_CONSTANT,
             value=fill_value,
-        )  # type: ignore[call-overload]
+        )
 
     def add_noise_salt_and_pepper(self, amount: float = 0.05) -> None:
         """Add salt and pepper noise to the image.

poetry.lock

@@ -26,6 +26,7 @@ pylint-exit = "^1.2.0"
 ruff = "^0.4.4"
 black = "^24.4.2"
 pre-commit = "^3.7.1"
+ty = "^0.0.14"
 
 [tool.poetry.group.dev.dependencies]
 setuptools = "^70.0.0"