fix: add copy in AxisAlignedRectangle since needed with new Rectangle copy method

Author: poupeaua

docs/img/badge-enjoy-otary-gradient.svg

@@ -192,3 +192,13 @@ def rotate_transform(
             is_clockwise=is_clockwise,
         )
         return Rectangle(points=rot_points)
+
+    def copy(self) -> AxisAlignedRectangle:
+        """Create a copy of the AxisAlignedRectangle object.
+
+        Returns:
+            AxisAlignedRectangle: copy of the object
+        """
+        return AxisAlignedRectangle(
+            points=self.asarray.copy(), is_cast_int=self.is_cast_int
+        )

otary/geometry/discrete/shape/axis_aligned_rectangle.py

@@ -351,10 +351,7 @@ def is_regular(self, margin_dist_error_pct: float = 1e-2) -> bool:
         cross_point = intersection_points[0]
         dist_mid_cross_diag1 = np.linalg.norm(cross_point - diag1.centroid)
         dist_mid_cross_diag2 = np.linalg.norm(cross_point - diag2.centroid)
-        if (
-            dist_mid_cross_diag1 > err_tol
-            or dist_mid_cross_diag2 > err_tol
-        ):
+        if dist_mid_cross_diag1 > err_tol or dist_mid_cross_diag2 > err_tol:
             return False
 
         return True

otary/geometry/discrete/shape/polygon.py

@@ -41,7 +41,7 @@ def __init__(
                 on initialization. Must be in [0, 1]. Defaults to 1e-2.
             desintersect (bool, optional): whether to desintersect the rectangle or not.
                 Can be useful if the input points are in a random order and
-                self-intersection is possible. If you try to force to 
+                self-intersection is possible. If you try to force to
                 instantiate a self-intersected rectangle a ValueError will be raised.
                 Defaults to True.
         """
@@ -64,7 +64,7 @@ def __init__(
                 "do not form a valid Rectangle. Please check your input coordinates, "
                 "the regularity_rtol and the desintersect parameters."
             )
-        
+
         self.regularity_rtol = regularity_rtol
 
     @classmethod
@@ -450,14 +450,14 @@ def get_vector_left_from_topleft(self, topleft_index: int) -> Vector:
             topleft_index=topleft_index, vertice="topright"
         )
         return Vector([self[topleft_index], rect_topright_vertice])
-    
-    def copy(self) -> Self:
+
+    def copy(self) -> Rectangle:
         """Create a copy of the Rectangle object.
 
         Returns:
             Rectangle: new Rectangle object
         """
-        # having a dedicated copy method is important here because of the 
+        # having a dedicated copy method is important here because of the
         # regularity_rtol attribute in the special case of the Rectangle class.
         return Rectangle(
             points=self.asarray.copy(),

otary/geometry/discrete/shape/rectangle.py

@@ -166,3 +166,25 @@ def test_rotate_raises(self):
         # Attempt to rotate the rectangle by 45 degrees
         with pytest.raises(TypeError):
             rect.rotate(angle=45)
+
+
+class TestAxisAlignedRectangleCopy:
+
+    def test_copy_base(self):
+        # Create an axis-aligned rectangle
+        rect = AxisAlignedRectangle.from_topleft(topleft=[1, 1], width=3, height=2)
+
+        # Create a copy of the rectangle
+        rect_copy = rect.copy()
+
+        assert isinstance(rect_copy, AxisAlignedRectangle)
+
+        # Assert the copy has the same properties as the original
+        assert rect_copy.xmin == rect.xmin
+        assert rect_copy.ymin == rect.ymin
+        assert rect_copy.xmax == rect.xmax
+        assert rect_copy.ymax == rect.ymax
+        assert (rect_copy.asarray == rect.asarray).all()
+
+        # Assert the copy is a different object
+        assert rect_copy is not rect

tests/unit/geometry/discrete/shape/test_axis_aligned_rectangle.py

@@ -328,10 +328,12 @@ class TestRectangleCopy:
 
     def test_copy(self):
         """Useful test where a Rectangle that is not that regular should be copied
-        with the same not that regular condition. 
+        with the same not that regular condition.
         """
-        rect = Rectangle([[422, 440], [419, 470], [499, 476], [500, 445]], regularity_rtol=1e-1)
+        rect = Rectangle(
+            [[422, 440], [419, 470], [499, 476], [500, 445]], regularity_rtol=1e-1
+        )
         rect_copy = rect.copy()
         assert rect is not rect_copy
         assert np.array_equal(rect.asarray, rect_copy.asarray)
-        assert rect.regularity_rtol == rect_copy.regularity_rtol
+        assert rect.regularity_rtol == rect_copy.regularity_rtol