Merge pull request #581 from powerapi-ng/refactor/function-call-in-default-argument

refactor: Remove function call in default arguments

Author: gfieni

.ruff.toml

@@ -17,7 +17,7 @@ ignore = [
     "E501",   # line too long
 
     "B006",   # mutable-argument-default
-    "B008",   # function-call-in-default-argument
+    # "B008",   # function-call-in-default-argument
     "F401",   # unused-import
     "RUF013", # implicit-optional
 

src/powerapi/report/procfs_report.py

@@ -153,9 +153,9 @@ def _create_cgroup(_, cgroup_name, usage):
             usage[cgroup_name] = {}
 
 
-def create_report_root(cgroup_list, timestamp=datetime.fromtimestamp(0), sensor='toto', target='all'):
+def create_report_root(cgroup_list, timestamp=None, sensor='toto', target='all'):
     """ Create a default procfs report """
-    sensor = ProcfsReport(timestamp=timestamp, sensor=sensor, target=target, usage={}, global_cpu_usage=0)
+    sensor = ProcfsReport(timestamp=timestamp or datetime.now(), sensor=sensor, target=target, usage={}, global_cpu_usage=0)
     for (cgroup_id, cpu_usage) in cgroup_list:
         sensor.usage[cgroup_id] = cpu_usage
     return sensor

tests/unit/dispatch_rule/test_hwpc_dispatch_rule.py

@@ -73,8 +73,8 @@ def create_group_report(group_id, socket_list):
     return (group_id, group)
 
 
-def create_report_root(group_list, timestamp=datetime.fromtimestamp(0), sensor='toto', target='system'):
-    sensor = HWPCReport(timestamp=timestamp, sensor=sensor, target=target, groups={})
+def create_report_root(group_list, timestamp=None, sensor='toto', target='system'):
+    sensor = HWPCReport(timestamp=timestamp or datetime.now(), sensor=sensor, target=target, groups={})
     for (group_id, group) in group_list:
         sensor.groups[group_id] = group
     return sensor

tests/unit/dispatcher/test_dispatcher_actor.py

@@ -82,8 +82,8 @@ class Report1(Report):
         Fake report that can contain 2 or three values *a*, *b*, and *b2*
     """
 
-    def __init__(self, a, b, b2=None, timestamp=datetime.now(), sensor='test_sensor', target='test_target'):
-        Report.__init__(self, timestamp=timestamp, target=target, sensor=sensor)
+    def __init__(self, a, b, b2=None, timestamp=None, sensor='test_sensor', target='test_target'):
+        Report.__init__(self, timestamp=timestamp or datetime.now(), target=target, sensor=sensor)
         self.a = a
         self.b = b
         self.b2 = b2
@@ -141,8 +141,8 @@ class Report2(Report):
         Fake report that can contains two or three values : *a*, *c*, *c2*
     """
 
-    def __init__(self, a, c, c2=None, timestamp=datetime.now(), sensor='test_sensor', target='test_target'):
-        Report.__init__(self, timestamp=timestamp, target=target, sensor=sensor)
+    def __init__(self, a, c, c2=None, timestamp=None, sensor='test_sensor', target='test_target'):
+        Report.__init__(self, timestamp=timestamp or datetime.now(), target=target, sensor=sensor)
         self.a = a
         self.c = c
         self.c2 = c2
@@ -199,8 +199,8 @@ class Report3(Report):
         Fake report that contains same values as Report 1 and an other value
     """
 
-    def __init__(self, a, b, d, timestamp=datetime.now(), sensor='test_sensor', target='test_target'):
-        Report.__init__(self, timestamp=timestamp, target=target, sensor=sensor)
+    def __init__(self, a, b, d, timestamp=None, sensor='test_sensor', target='test_target'):
+        Report.__init__(self, timestamp=timestamp or datetime.now(), target=target, sensor=sensor)
         self.a = a
         self.b = b
         self.d = d