Merge pull request #544 from powerapi-ng/refactor/type-comparison

refactor: Use `is` instead of `==` to compare types

Author: gfieni

.ruff.toml

@@ -30,7 +30,6 @@ ignore = [
     "B011",   # assert-false
     "B017",   # assert-raises-exception
     "B905",   # zip-without-explicit-strict
-    "E721",   # type-comparison
     "PT001",  # pytest-fixture-incorrect-parentheses-style
     "PT011",  # pytest-raises-too-broad
     "PT012",  # pytest-raises-with-multiple-statements

tests/unit/cli/test_parsing_manager.py

@@ -732,7 +732,7 @@ def test_parsing_configuration_file_with_unknown_argument_terminate_execution_in
     with pytest.raises(SystemExit) as result:
         _ = root_config_parsing_manager_with_mandatory_and_optional_arguments.parse(args=f'--config-file {test_files_path}/{config_file}'.split())
 
-    assert result.type == SystemExit
+    assert result.type is SystemExit
     assert result.value.code == -1
 
 
@@ -746,7 +746,7 @@ def test_parsing_configuration_file_with_wrong_argument_terminate_execution_in_r
     with pytest.raises(SystemExit) as result:
         _ = root_config_parsing_manager_with_mandatory_and_optional_arguments.parse(args=('--config-file ' + test_files_path + '/' + config_file).split())
 
-    assert result.type == SystemExit
+    assert result.type is SystemExit
     assert result.value.code == -1
 
 
@@ -807,7 +807,7 @@ def test_parsing_cli_configuration_with_unknown_argument_terminate_execution_in_
     with pytest.raises(SystemExit) as result:
         _ = root_config_parsing_manager_with_mandatory_and_optional_arguments.parse()
 
-    assert result.type == SystemExit
+    assert result.type is SystemExit
     assert result.value.code == -1
 
 
@@ -850,7 +850,7 @@ def test_parsing_environment_variables_with_unknown_argument_terminate_execution
     with pytest.raises(SystemExit) as result:
         _ = root_config_parsing_manager_with_mandatory_and_optional_arguments.parse()
 
-    assert result.type == SystemExit
+    assert result.type is SystemExit
     assert result.value.code == -1
 
     remove_environment_variables_configuration(variables_names=created_environment_variables)
@@ -1077,7 +1077,7 @@ def test_parsing_environment_variables_with_subgroups_and_unknown_arguments_term
     with pytest.raises(SystemExit) as result:
         _ = root_config_parsing_manager_with_mandatory_and_optional_arguments.parse()
 
-    assert result.type == SystemExit
+    assert result.type is SystemExit
     assert result.value.code == -1
 
     remove_environment_variables_configuration(variables_names=created_environment_variables)
@@ -1126,7 +1126,7 @@ def test_parsing_environment_variables_with_subgroups_and_wrong_type_terminate_e
     with pytest.raises(SystemExit) as result:
         _ = root_config_parsing_manager_with_mandatory_and_optional_arguments.parse()
 
-    assert result.type == SystemExit
+    assert result.type is SystemExit
     assert result.value.code == -1
 
     remove_environment_variables_configuration(variables_names=created_environment_variables)
@@ -1287,5 +1287,5 @@ def test_add_repeated_subgroup_terminate_execution_in_root_parsing_manager(root_
     with pytest.raises(SystemExit) as result:
         _ = root_config_parsing_manager.add_subgroup(name='sub')
 
-    assert result.type == SystemExit
+    assert result.type is SystemExit
     assert result.value.code == -1