!feat(formula): Use report type to pusher actor mapping for actor

Change the `pushers` argument of the `FormulaActor` class from a dict
mapping the actor name to a pusher actor to a dict mapping the report
type to a list of pusher actors.

This allow to have a more efficient dispatch of the generated reports to
theirs corresponding pushers in the formula report handlers.

Author: gfieni

src/powerapi/dispatcher/dispatcher_actor.py

@@ -46,7 +46,7 @@ class DispatcherState(State):
     Dispatcher actor state.
     """
 
-    def __init__(self, actor, pushers: dict[str, PusherActor], route_table: RouteTable):
+    def __init__(self, actor, pushers: dict[type[Report], list[PusherActor]], route_table: RouteTable):
         """
         :param actor: Dispatcher actor instance
         :param pushers: List of pushers
@@ -90,8 +90,8 @@ class DispatcherActor(Actor):
     provided routing table. When a report doesn't have any formula assigned, the dispatcher will create a new formula.
     """
 
-    def __init__(self, name: str, formula_init_function: Callable, pushers: [], route_table: RouteTable,
-                 level_logger: Literal = logging.WARNING, timeout=None):
+    def __init__(self, name: str, formula_init_function: Callable, pushers: dict[type[Report], list[PusherActor]],
+                 route_table: RouteTable, level_logger: int = logging.WARNING, timeout=None):
         """
         :param name: Actor name
         :param formula_init_function: Factory function for creating Formula

src/powerapi/formula/formula_actor.py

@@ -32,6 +32,7 @@
 
 from powerapi.actor import Actor, State
 from powerapi.pusher import PusherActor
+from powerapi.report import Report
 
 
 class FormulaState(State):
@@ -53,7 +54,7 @@ class FormulaActor(Actor):
     Abstract actor class used to implement formula actor that compute power consumption of a device from Reports
     """
 
-    def __init__(self, name, pushers: dict[str, PusherActor], level_logger=logging.WARNING, timeout=None):
+    def __init__(self, name, pushers: dict[type[Report], PusherActor], level_logger=logging.WARNING, timeout=None):
         """
         Initialize a new Formula actor.
         :param name: Actor name
@@ -86,5 +87,6 @@ def setup(self):
         """
         Setup the Formula actor.
         """
-        for _, pusher in self.state.pushers.items():
-            pusher.connect_data()
+        for pushers in self.state.pushers.values():
+            for pusher in pushers:
+                pusher.connect_data()

src/powerapi/formula/handlers.py

@@ -35,5 +35,6 @@ class FormulaPoisonPillMessageHandler(PoisonPillMessageHandler):
     Default Handler for dealing with PoisonPillMessage
     """
     def teardown(self, soft=False):
-        for _, pusher in self.state.pushers.items():
-            pusher.socket_interface.close()
+        for pushers in self.state.pushers.values():
+            for pusher in pushers:
+                pusher.socket_interface.close()

tests/unit/dispatcher/test_dispatcher_actor.py

@@ -290,7 +290,7 @@ def actor(request, dispatch_rules, started_fake_pusher_power_report):
         def formula_factory(name, pushers):
             return DummyFormulaActor(name, pushers, 0, 0)
 
-        reports_pusher = {PUSHER_NAME_POWER_REPORT: started_fake_pusher_power_report}
+        reports_pusher = {Report: [started_fake_pusher_power_report]}
         name = f'{request.node.name}_dispatcher'
         actor = DispatcherActor(name, formula_factory, reports_pusher, route_table)
 

tests/utils/formula/dummy/dummy_handlers.py

@@ -58,6 +58,10 @@ def handle(self, msg):
         :param powerapi.Report msg:  Received message
         """
         results = self._estimate(msg)
-        for _, actor_pusher in self.state.pushers.items():
-            for result in results:
-                actor_pusher.send_data(result)
+
+        # Send the reports to every available pusher because a lot of unit tests don't set up their test actor correctly.
+        # FIXME: Reports should only be sent to theirs corresponding pusher(s)
+        for pushers in self.state.pushers.values():
+            for pusher in pushers:
+                for result in results:
+                    pusher.send_data(result)