Skip to content

Commit 014138b

Browse files
committed
Implemented minor PR feedback.
1 parent 9bac6b6 commit 014138b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/web/src/db/adapters/wa-sqlite/WASQLiteDBAdapter.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ export class WASQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
107107
: getWorkerDatabaseOpener(this.options.dbFilename, enableMultiTabs, optionsDbWorker);
108108

109109
this.methods = await dbOpener(this.options.dbFilename);
110-
111-
await this.methods?.execute(tempStoreQuery);
110+
await this.methods!.execute(tempStoreQuery);
112111
this.methods.registerOnTableChange(
113112
Comlink.proxy((event) => {
114113
this.iterateListeners((cb) => cb.tablesUpdated?.(event));
@@ -118,7 +117,7 @@ export class WASQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
118117
return;
119118
}
120119
this.methods = await _openDB(this.options.dbFilename, { useWebWorker: false });
121-
await this.methods?.execute(tempStoreQuery);
120+
await this.methods!.execute(tempStoreQuery);
122121
this.methods.registerOnTableChange((event) => {
123122
this.iterateListeners((cb) => cb.tablesUpdated?.(event));
124123
});

packages/web/src/db/adapters/web-sql-flags.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ export interface ResolvedWebSQLOpenOptions extends SQLOpenOptions {
4343
}
4444

4545
export enum TemporaryStorageOption {
46-
MEMORY = 'memory;',
47-
FILESYSTEM = 'file;'
46+
MEMORY = 'memory',
47+
FILESYSTEM = 'file'
4848
}
4949

5050
/**
@@ -63,6 +63,7 @@ export interface WebSQLOpenFactoryOptions extends SQLOpenOptions {
6363

6464
/**
6565
* Where to store SQLite temporary files. Defaults to 'MEMORY'.
66+
* Setting this to `FILESYSTEM` can cause issues with larger queries or datasets.
6667
*/
6768
temporaryStorage?: TemporaryStorageOption;
6869
}

0 commit comments

Comments
 (0)