chore: avoid breaking change

Author: DominicGBauer

packages/common/src/client/AbstractPowerSyncDatabase.ts

@@ -39,6 +39,10 @@ export interface DisconnectAndClearOptions {
 export interface BasePowerSyncDatabaseOptions extends AdditionalConnectionOptions {
   /** Schema used for the local database. */
   schema: Schema;
+  /**
+   * @deprecated Use {@link retryDelayMs} instead as this will be removed in future releases.
+   */
+  retryDelay?: number;
   logger?: ILogger;
 }
 

packages/react-native/src/db/PowerSyncDatabase.ts

@@ -1,6 +1,7 @@
 import {
   AbstractPowerSyncDatabase,
   AbstractStreamingSyncImplementation,
+  AdditionalConnectionOptions,
   BucketStorageAdapter,
   DBAdapter,
   PowerSyncBackendConnector,
@@ -44,14 +45,11 @@ export class PowerSyncDatabase extends AbstractPowerSyncDatabase {
   protected generateSyncStreamImplementation(
     connector: PowerSyncBackendConnector,
     // This is used to pass in options on connection instead of only during database creation
-    options?: {
-      retryDelayMs: number;
-      crudUploadThrottleMs: number;
-    }
+    options?: AdditionalConnectionOptions
   ): AbstractStreamingSyncImplementation {
     const remote = new ReactNativeRemote(connector);
     // Use the options passed in during connect, or fallback to the options set during database creation
-    const retryDelayMs = options?.retryDelayMs ?? this.options.retryDelayMs;
+    const retryDelayMs = options?.retryDelayMs ?? this.options.retryDelayMs ?? this.options.retryDelay;
     const crudUploadThrottleMs = options?.crudUploadThrottleMs ?? this.options.crudUploadThrottleMs;
 
     return new ReactNativeStreamingSyncImplementation({

packages/web/src/db/PowerSyncDatabase.ts

@@ -172,7 +172,7 @@ export class PowerSyncDatabase extends AbstractPowerSyncDatabase {
   ): StreamingSyncImplementation {
     const remote = new WebRemote(connector);
     // Use the options passed in during connect, or fallback to the options set during database creation
-    const retryDelayMs = options?.retryDelayMs ?? this.options.retryDelayMs;
+    const retryDelayMs = options?.retryDelayMs ?? this.options.retryDelayMs ?? this.options.retryDelay;
     const crudUploadThrottleMs = options?.crudUploadThrottleMs ?? this.options.crudUploadThrottleMs;
 
     const syncOptions: WebStreamingSyncImplementationOptions = {

packages/web/tests/src/db/PowersyncDatabase.test.ts

@@ -97,4 +97,26 @@ describe('PowerSyncDatabase - generateSyncStreamImplementation', () => {
       })
     )
   })
+
+  // This test can be removed once retryDelay is removed and entirely replaced with retryDelayMs
+  it('works when using deprecated retryDelay instead of retryDelayMs', () => {
+    const db = new PowerSyncDatabase({
+      schema: testSchema,
+      database: {
+        dbFilename: 'test.db'
+      },
+      flags: {
+        ssrMode: false,
+        enableMultiTabs: false,
+      },
+      retryDelay: 11100,
+    })
+
+    db['generateSyncStreamImplementation'](mockConnector)
+    expect(WebStreamingSyncImplementation).toHaveBeenCalledWith(
+      expect.objectContaining({
+        retryDelayMs: 11100,
+      })
+    )
+  })
 })