Ignore exceptions during rollback

simolus3 · simolus3 · commit 6cbc4058edf0 · 2025-03-05T09:53:50.000+01:00
diff --git a/packages/node/src/db/BetterSQLite3DBAdapter.ts b/packages/node/src/db/BetterSQLite3DBAdapter.ts
@@ -226,7 +226,12 @@ export class BetterSQLite3DBAdapter extends BaseObserver<DBAdapterListener> impl
       await commit();
       return result;
     } catch (ex) {
-      await rollback();
+      try {
+        await rollback();
+      } catch (ex2) {
+        // In rare cases, a rollback may fail.
+        // Safe to ignore.
+      }
       throw ex;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,12 @@ export class BetterSQLite3DBAdapter extends BaseObserver<DBAdapterListener> impl`
`226`	`226`	`await commit();`
`227`	`227`	`return result;`
`228`	`228`	`} catch (ex) {`
`229`		`- await rollback();`
	`229`	`+ try {`
	`230`	`+ await rollback();`
	`231`	`+ } catch (ex2) {`
	`232`	`+ // In rare cases, a rollback may fail.`
	`233`	`+ // Safe to ignore.`
	`234`	`+ }`
`230`	`235`	`throw ex;`
`231`	`236`	`}`
`232`	`237`	`}`