tests(WIP:) initial node setup and few bug fixes

Author: Amine

.gitignore

@@ -9,3 +9,5 @@ dist
 # Useful if running repository in VSCode dev container
 .pnpm-store
 __screenshots__
+**/tests/temp/**/*
+**/tests/temp/**/.*

packages/attachments/package.json

@@ -50,7 +50,10 @@
   "devDependencies": {
     "@powersync/common": "workspace:*",
     "@powersync/web": "workspace:*",
+    "@powersync/node": "workspace:*",
+    "@powersync/better-sqlite3": "^0.2.0",
     "@types/node": "^20.17.6",
+    "memfs": "^4.50.0",
     "vite": "^6.1.0",
     "vite-plugin-top-level-await": "^1.4.4",
     "vite-plugin-wasm": "^3.3.0"

packages/attachments/src/AttachmentContext.ts

@@ -118,36 +118,52 @@ export class AttachmentContext {
    * @param context - Active database transaction context
    */
   upsertAttachment(attachment: AttachmentRecord, context: Transaction): void {
-    context.execute(
-      /* sql */
-      `
-        INSERT
-        OR REPLACE INTO ${this.tableName} (
-          id,
-          filename,
-          local_uri,
-          size,
-          media_type,
-          timestamp,
-          state,
-          has_synced,
-          meta_data
-        )
-        VALUES
-          (?, ?, ?, ?, ?, ?, ?, ?, ?)
-      `,
-      [
-        attachment.id,
-        attachment.filename,
-        attachment.localUri || null,
-        attachment.size || null,
-        attachment.mediaType || null,
-        attachment.timestamp,
-        attachment.state,
-        attachment.hasSynced ? 1 : 0,
-        attachment.metaData || null
-      ]
-    );
+    console.debug('[ATTACHMENT CONTEXT] Upserting attachment:', [
+      attachment.id,
+      attachment.filename,
+      attachment.localUri || null,
+      attachment.size || null,
+      attachment.mediaType || null,
+      attachment.timestamp,
+      attachment.state,
+      attachment.hasSynced ? 1 : 0,
+      attachment.metaData || null
+    ]);
+    try {
+      context.execute(
+        /* sql */
+        `
+          INSERT
+          OR REPLACE INTO ${this.tableName} (
+            id,
+            filename,
+            local_uri,
+            size,
+            media_type,
+            timestamp,
+            state,
+            has_synced,
+            meta_data
+          )
+          VALUES
+            (?, ?, ?, ?, ?, ?, ?, ?, ?)
+        `,
+        [
+          attachment.id,
+          attachment.filename,
+          attachment.localUri || 'dummy',
+          attachment.size || 1,
+          attachment.mediaType || 'dummy',
+          attachment.timestamp || Date.now(),
+          attachment.state,
+          attachment.hasSynced ? 1 : 0,
+          attachment.metaData || 'dummy'
+        ]
+      );
+    } catch (error) {
+      console.error('[ATTACHMENT CONTEXT] Error upserting attachment:', attachment.id?.substring(0,8), attachment.state, error);
+      throw error;
+    }
   }
 
   /**
@@ -182,7 +198,9 @@ export class AttachmentContext {
    * @param attachments - Array of attachment records to save
    */
   async saveAttachments(attachments: AttachmentRecord[]): Promise<void> {
+    console.debug('[ATTACHMENT CONTEXT] Saving attachments:', attachments.map(a => ({ id: a.id?.substring(0,8), state: a.state })));
     if (attachments.length === 0) {
+      console.debug('[ATTACHMENT CONTEXT] No attachments to save');
       return;
     }
     await this.db.writeTransaction(async (tx) => {

packages/attachments/src/AttachmentQueue.ts

@@ -7,6 +7,8 @@ import { SyncingService } from './SyncingService.js';
 import { WatchedAttachmentItem } from './WatchedAttachmentItem.js';
 import { AttachmentService } from './AttachmentService.js';
 
+export type AttachmentData = ArrayBuffer | Blob | string;
+
 /**
  * AttachmentQueue manages the lifecycle and synchronization of attachments
  * between local and remote storage.
@@ -94,6 +96,7 @@ export class AttachmentQueue {
     downloadAttachments?: boolean;
     archivedCacheLimit?: number;
   }) {
+    console.debug('AttachmentQueue constructor')
     this.context = new AttachmentContext(db, tableName, logger ?? db.logger);
     this.remoteStorage = remoteStorage;
     this.localStorage = localStorage;
@@ -133,7 +136,12 @@ export class AttachmentQueue {
    * - Handles state transitions for archived and new attachments
    */
   async startSync(): Promise<void> {
-    await this.stopSync();
+    console.debug('[QUEUE] AttachmentQueue startSync')
+    if (this.attachmentService.watchActiveAttachments) {
+      await this.stopSync();
+      // re-create the watch after it was stopped
+      this.watchActiveAttachments = this.attachmentService.watchActiveAttachments();
+    }
 
     // Sync storage periodically
     this.periodicSyncTimer = setInterval(async () => {
@@ -143,12 +151,14 @@ export class AttachmentQueue {
     // Sync storage when there is a change in active attachments
     this.watchActiveAttachments.registerListener({
       onDiff: async () => {
+        console.debug('[QUEUE] watchActiveAttachments: diff detected, syncing storage');
         await this.syncStorage();
       }
     });
 
     // Process attachments when there is a change in watched attachments
     this.watchAttachments(async (watchedAttachments) => {
+      console.debug('[QUEUE] watchAttachments callback:', watchedAttachments.length, 'items');
       // Need to get all the attachments which are tracked in the DB.
       // We might need to restore an archived attachment.
       const currentAttachments = await this.context.getAttachments();
@@ -224,6 +234,7 @@ export class AttachmentQueue {
       }
 
       if (attachmentUpdates.length > 0) {
+        console.debug('[QUEUE] Saving attachments:', attachmentUpdates);
         await this.context.saveAttachments(attachmentUpdates);
       }
     });
@@ -237,6 +248,7 @@ export class AttachmentQueue {
    */
   async syncStorage(): Promise<void> {
     const activeAttachments = await this.context.getActiveAttachments();
+    console.debug('[QUEUE] syncStorage: processing', activeAttachments.length, 'active attachments');
     await this.localStorage.initialize();
     await this.syncingService.processAttachments(activeAttachments);
     await this.syncingService.deleteArchivedAttachments();
@@ -275,7 +287,7 @@ export class AttachmentQueue {
     updateHook
   }: {
     // TODO: create a dedicated type for data
-    data: ArrayBuffer | Blob | string;
+    data: AttachmentData;
     fileExtension: string;
     mediaType?: string;
     metaData?: string;

packages/attachments/src/SyncingService.ts

@@ -107,9 +107,10 @@ export class SyncingService {
    * @returns Updated attachment record with local URI and new state
    */
   async downloadAttachment(attachment: AttachmentRecord): Promise<AttachmentRecord> {
+    console.debug('[SYNC] Downloading:', attachment.id);
     try {
       const file = await this.remoteStorage.downloadFile(attachment);
-
+      console.debug('[SYNC] Downloaded, converting to base64');
       const base64Data = await new Promise<string>((resolve, reject) => {
         const reader = new FileReader();
         reader.onloadend = () => {