Skip to content

Commit fc99b93

Browse files
committed
Minor readme change, updated a comment.
1 parent aa04921 commit fc99b93

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/dev/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# PowerSync Dev
22

33
A development package for PowerSync which uses [SQL.js](https://sql.js.org/#/) to provide a pure JavaScript SQLite implementation.
4-
This eliminates the need for native dependencies and enabling seamless development with Expo Go and other JavaScript-only environments.
4+
This eliminates the need for native dependencies and enables seamless development with Expo Go and other JavaScript-only environments.
55

66
This package is specifically designed to streamline the development workflow and will be much slower than DB adapters that use native dependencies.
7-
For example when building React Native apps we recommend switching to our OP-sqlite or RNQS adapters when making production builds as they give substantially better performance.
7+
For example, when building React Native apps we recommend switching to our [react-native-quick-sqlite](https://www.npmjs.com/package/@journeyapps/react-native-quick-sqlite) or [OP-SQLite](https://www.npmjs.com/package/@powersync/op-sqlite) adapters when making production builds as they give substantially better performance.
88

99
## Note: Alpha Release
1010

packages/dev/src/SQLJSAdapter.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,8 @@ export class SQLJSDBAdapter extends BaseObserver<DBAdapterListener> implements D
159159
return Object.fromEntries(row.map((value, index) => [columnNames![index], value]));
160160
});
161161
return {
162-
insertId: (db as any).lastInsertId(), // does not seem to be available in SQL.js??
162+
// `lastInsertId` is not available in the original version of SQL.js or its types, but it's available in the fork we use.
163+
insertId: (db as any).lastInsertId(),
163164
rowsAffected: db.getRowsModified(),
164165
rows: {
165166
_array: rows,

0 commit comments

Comments
 (0)