feat: Add FetchStrategy option to connect() for WebSockets #494
Conversation
🦋 Changeset detectedLatest commit: 93615f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…either `buffered` or `sequential` for the Websocket connect option.
Chriztiaan
force-pushed
the
test-slower-sockets
branch
from
f3d016c to
03ec45e
Compare
Chriztiaan
changed the title
There was a problem hiding this comment.
Do you know what is specifically causing the issue?
For example, is the bson stream parsing adding so much overhead on a slow react-native device that we can't even send keepalive packet? If that's the case, could we do something like throttle the bson parsing to avoid that?
Or is there a more fundamental issue with having a queue backlog?
In general, it would be great if we could auto-manage this, without the developer having to figure out which option to use for their use case.
3 participants
This allows the fetch strategy to be configured, with the actual functionality addition being the
sequentialoption.When specifying
sequential:Instead of queueing up multiple sync events (10 originally) before applying them, which would lead to less round-trips - we are configuring the queue size to 1, meaning each event will get processed individually before asking for the next.
This results in less overhead processing of the netword events (pending items) and should free up the web socket for better keep alive acknowledgements.
Currently this resolves a known issue on slower devices with large sync datasets.