Remove Old Mutex #662
Merged
Remove Old Mutex #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88fbaf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
What was affected by this? |
|
The only affect I can think of is in the Node.js SDK: calls to |
stevensJourney
commented
Jul 11, 2025
rkistner
approved these changes
Jul 11, 2025
whygee-dev
pushed a commit
to whygee-dev/powersync-js
that referenced
this pull request
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The very first version of the JS SDK used a shared mutex instance for read and write locks. Future versions moved the locking to the
DBAdapterinterface.The
AbstractPowerSyncDatabasestill contained the shared mutex code which was used in the commonreadLockandwriteLockimplementations.Using the same mutex for
readLockandwriteLockbreaks concurrency. The React native SDK had an override for thereadLockandwriteLockmethod which avoided this issue. Web only has a single connection, so concurrency wasn't an issue there. The Node.js SDK however would rely on the common implementation and would therefore have some concurrency issues. Luckily the individualget,getAllandgetOptionalmethods go through theDBAdapterand not thereadLockAPI. Currency was only partially broken for the Node.js SDK.This PR removes the old mutex entirely.