Skip to content

Commit 826e7a3

Browse files
committed
Get rid of generateLogger()
1 parent a0c2245 commit 826e7a3

File tree

3 files changed

+18
-29
lines changed

3 files changed

+18
-29
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
* Fixed modifying severity of the global Kermit logger
66
* Added `PowerSync` tag for the logs
7+
* Removed `generateLogger()` global public method meant to be used internally
78

89
## 1.4.0
910

core/src/commonMain/kotlin/com/powersync/PowerSyncDatabaseFactory.kt

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
package com.powersync
22

3+
import BuildConfig
34
import co.touchlab.kermit.Logger
5+
import co.touchlab.kermit.Severity
6+
import co.touchlab.kermit.StaticConfig
7+
import co.touchlab.kermit.platformLogWriter
48
import co.touchlab.skie.configuration.annotations.DefaultArgumentInterop
59
import com.powersync.db.PowerSyncDatabaseImpl
610
import com.powersync.db.schema.Schema
7-
import com.powersync.utils.generateLogger
811
import kotlinx.coroutines.CoroutineScope
912
import kotlinx.coroutines.DelicateCoroutinesApi
1013
import kotlinx.coroutines.GlobalScope
@@ -27,18 +30,25 @@ public fun PowerSyncDatabase(
2730
* This parameter is ignored for iOS.
2831
*/
2932
dbDirectory: String? = null,
30-
): PowerSyncDatabase {
31-
val generatedLogger: Logger = generateLogger(logger)
32-
33-
return createPowerSyncDatabaseImpl(
33+
): PowerSyncDatabase =
34+
createPowerSyncDatabaseImpl(
3435
schema = schema,
3536
factory = factory,
3637
dbFilename = dbFilename,
3738
scope = scope,
38-
logger = generatedLogger,
39+
logger = logger
40+
?: Logger(
41+
config = StaticConfig(
42+
logWriterList = listOf(platformLogWriter()),
43+
minSeverity = if (BuildConfig.isDebug)
44+
Severity.Verbose
45+
else
46+
Severity.Warn
47+
),
48+
tag = "PowerSync",
49+
),
3950
dbDirectory = dbDirectory,
4051
)
41-
}
4252

4353
internal fun createPowerSyncDatabaseImpl(
4454
factory: DatabaseDriverFactory,

core/src/commonMain/kotlin/com/powersync/utils/Log.kt

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)