Skip to content

Commit 8567a98

Browse files
committed
Do not modify global Kermit severity
1 parent 4311ec1 commit 8567a98

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
* Fixed modifying severity of the global Kermit logger
6+
37
## 1.4.0
48

59
* Added the ability to log PowerSync service HTTP request information via specifying a
Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,21 @@
11
package com.powersync.utils
22

3-
import co.touchlab.kermit.Logger
4-
import co.touchlab.kermit.Severity
3+
import BuildConfig
4+
import co.touchlab.kermit.*
55

66
/*
77
* Generates a logger with the appropriate severity level based on the build type
88
* if no Logger is provided.
99
*/
1010
public fun generateLogger(logger: Logger?): Logger {
11-
if (logger != null) {
12-
return logger
13-
}
14-
15-
val defaultLogger: Logger = Logger
16-
17-
if (BuildConfig.isDebug) {
18-
Logger.setMinSeverity(Severity.Verbose)
19-
} else {
20-
Logger.setMinSeverity(Severity.Warn)
21-
}
22-
23-
return defaultLogger
11+
return logger
12+
?: Logger(
13+
config = StaticConfig(
14+
logWriterList = listOf(platformLogWriter()),
15+
minSeverity = if (BuildConfig.isDebug)
16+
Severity.Verbose
17+
else
18+
Severity.Warn
19+
),
20+
)
2421
}

0 commit comments

Comments
 (0)