Update table-valued functions test as well

Author: simolus3

.changeset/olive-games-destroy.md

@@ -0,0 +1,6 @@
+---
+'@powersync/service-sync-rules': minor
+'@powersync/service-image': minor
+---
+
+Add the `legacy_json_extract` quirk. When marked as fixed, JSON-extracting operators are updated to match SQLite more closely.

packages/sync-rules/test/src/table_valued_function_queries.test.ts

@@ -1,5 +1,11 @@
 import { describe, expect, test } from 'vitest';
-import { RequestParameters, SqlParameterQuery } from '../../src/index.js';
+import {
+  CompatibilityContext,
+  CompatibilityEdition,
+  CompatibilityOption,
+  RequestParameters,
+  SqlParameterQuery
+} from '../../src/index.js';
 import { StaticSqlParameterQuery } from '../../src/StaticSqlParameterQuery.js';
 import { identityBucketTransformer, PARSE_OPTIONS } from './util.js';
 
@@ -20,13 +26,45 @@ describe('table-valued function queries', () => {
 
     expect(
       query.getStaticBucketDescriptions(
-        new RequestParameters({ sub: '' }, { array: [1, 2, 3] }),
+        new RequestParameters({ sub: '' }, { array: [1, 2, 3, null] }),
         identityBucketTransformer
       )
     ).toEqual([
       { bucket: 'mybucket[1]', priority: 3 },
       { bucket: 'mybucket[2]', priority: 3 },
-      { bucket: 'mybucket[3]', priority: 3 }
+      { bucket: 'mybucket[3]', priority: 3 },
+      { bucket: 'mybucket["null"]', priority: 3 }
+    ]);
+  });
+
+  test('json_each(array param), fixed json', function () {
+    const sql = "SELECT json_each.value as v FROM json_each(request.parameters() -> 'array')";
+    const query = SqlParameterQuery.fromSql(
+      'mybucket',
+      sql,
+      {
+        ...PARSE_OPTIONS,
+        accept_potentially_dangerous_queries: true,
+        compatibility: new CompatibilityContext(
+          CompatibilityEdition.LEGACY,
+          new Map([[CompatibilityOption.fixedJsonExtract, true]])
+        )
+      },
+      '1'
+    ) as StaticSqlParameterQuery;
+    expect(query.errors).toEqual([]);
+    expect(query.bucketParameters).toEqual(['v']);
+
+    expect(
+      query.getStaticBucketDescriptions(
+        new RequestParameters({ sub: '' }, { array: [1, 2, 3, null] }),
+        identityBucketTransformer
+      )
+    ).toEqual([
+      { bucket: 'mybucket[1]', priority: 3 },
+      { bucket: 'mybucket[2]', priority: 3 },
+      { bucket: 'mybucket[3]', priority: 3 },
+      { bucket: 'mybucket[null]', priority: 3 }
     ]);
   });