Reject static subqueries

Author: simolus3

packages/sync-rules/src/streams/from_sql.ts

@@ -1,21 +1,5 @@
 import { SqlRuleError } from '../errors.js';
-import {
-  ClauseError,
-  CompiledClause,
-  FilterParameters,
-  InputParameter,
-  ParameterMatchClause,
-  ParameterValueClause,
-  ParameterValueSet,
-  QueryParameters,
-  QuerySchema,
-  RowValueClause,
-  SqliteJsonValue,
-  SqliteValue,
-  StaticValueClause,
-  StreamParseOptions,
-  TrueIfParametersMatch
-} from '../types.js';
+import { CompiledClause, QuerySchema, StaticValueClause, StreamParseOptions } from '../types.js';
 import { isSelectStatement } from '../utils.js';
 import {
   andFilters,
@@ -72,7 +56,6 @@ class SyncStreamCompiler {
 
   compile(): SyncStream {
     const [stmt, ...illegalRest] = parse(this.sql, { locationTracking: true });
-    const errors: SqlRuleError[] = [];
 
     // TODO: Share more of this code with SqlDataQuery
     if (illegalRest.length > 0) {
@@ -100,7 +83,7 @@ class SyncStreamCompiler {
     stream.subscribedToByDefault = this.options.default ?? false;
     stream.variants = filter.compileVariants(this.descriptorName);
 
-    errors.push(...tools.errors);
+    this.errors.push(...tools.errors);
     return stream;
   }
 
@@ -282,7 +265,15 @@ class SyncStreamCompiler {
       }
       const [subquery, subqueryTools] = subqueryResult;
 
-      if (isStaticValueClause(left) || isParameterValueClause(left)) {
+      if (isStaticValueClause(left)) {
+        tools.error(
+          'For IN subqueries, the left operand must either depend on the row to sync or stream parameters.',
+          clause.left
+        );
+        return recoverErrorClause(tools);
+      }
+
+      if (isParameterValueClause(left)) {
         // Case 2: We can't implement this as an actual IN operator because we need to use exact parameter lookups (so
         // we can't, for instance, resolve `SELECT * FROM users WHERE is_admin` via parameter data sets). Since the
         // left clause doesn't depend on row data however, we can push it down into the subquery where it would be

packages/sync-rules/test/matchers.d.ts

@@ -0,0 +1,10 @@
+import 'vitest';
+
+interface CustomMatchers<R = unknown> {
+  toBeSqlRuleError: (message: string, location: string) => R;
+}
+
+declare module 'vitest' {
+  interface Assertion<T = any> extends CustomMatchers<T> {}
+  interface AsymmetricMatchersContaining extends CustomMatchers {}
+}

packages/sync-rules/test/matchers.ts

@@ -0,0 +1,29 @@
+import { beforeAll, expect } from 'vitest';
+import { SqlRuleError } from '../src/index.js';
+
+beforeAll(() => {
+  expect.extend({
+    toBeSqlRuleError(received, expectedMessage, expectedLocation) {
+      const { isNot } = this;
+
+      const message = () => {
+        return `expected ${received} ${isNot ? ' not' : ''} to be SQL error with ${expectedMessage} at ${expectedLocation}`;
+      };
+
+      if (received instanceof SqlRuleError) {
+        const actualLocation =
+          received.location && received.sql.substring(received.location.start, received.location.end);
+
+        return {
+          pass: received.message == expectedMessage && actualLocation == expectedLocation,
+          message
+        };
+      } else {
+        return {
+          pass: false,
+          message
+        };
+      }
+    }
+  });
+});

packages/sync-rules/test/src/streams.test.ts

@@ -1,3 +1,4 @@
+/// <reference path="../matchers.d.ts" />
 import { describe, expect, test } from 'vitest';
 import {
   BucketParameterQuerier,
@@ -126,6 +127,23 @@ describe('streams', () => {
     });
   });
 
+  describe('errors', () => {
+    test('IN operator with static left clause', () => {
+      const [_, errors] = syncStreamFromSql(
+        's',
+        "SELECT * FROM issues WHERE 'static' IN (SELECT id FROM users WHERE is_admin)",
+        options
+      );
+
+      expect(errors).toMatchObject([
+        expect.toBeSqlRuleError(
+          'For IN subqueries, the left operand must either depend on the row to sync or stream parameters.',
+          "'static'"
+        )
+      ]);
+    });
+  });
+
   /*
   test('static filter', () => {
     const desc = parseSingleBucketDescription(`

packages/sync-rules/vitest.config.ts

@@ -2,5 +2,7 @@ import { defineConfig } from 'vitest/config';
 
 export default defineConfig({
   plugins: [],
-  test: {}
+  test: {
+    setupFiles: ['test/matchers.ts']
+  }
 });