Fix mongodb as well

Author: simolus3

modules/module-mongodb/src/replication/MongoRelation.ts

@@ -1,16 +1,13 @@
 import { mongo } from '@powersync/lib-service-mongodb';
 import { storage } from '@powersync/service-core';
-import { JSONBig, JsonContainer } from '@powersync/service-jsonbig';
+import { JsonContainer } from '@powersync/service-jsonbig';
 import {
   CompatibilityContext,
   CustomArray,
   CustomObject,
   CustomSqliteValue,
-  DatabaseInputValue,
   SqliteInputRow,
   SqliteInputValue,
-  SqliteRow,
-  SqliteValue,
   DateTimeValue
 } from '@powersync/service-sync-rules';
 

modules/module-mongodb/test/src/mongo_test.test.ts

@@ -4,7 +4,9 @@ import {
   CompatibilityContext,
   CompatibilityEdition,
   SqliteInputRow,
-  SqlSyncRules
+  SqlSyncRules,
+  TimeValue,
+  CustomArray
 } from '@powersync/service-sync-rules';
 import { describe, expect, test } from 'vitest';
 
@@ -167,7 +169,7 @@ describe('mongo data types', () => {
 
     expect(sqliteValue[2]).toMatchObject({
       _id: 3n,
-      date: '2023-03-06 13:47:00.000Z'
+      date: new TimeValue('2023-03-06 13:47:00.000Z', '2023-03-06T13:47:00.000Z')
     });
 
     expect(sqliteValue[3]).toMatchObject({
@@ -221,7 +223,7 @@ describe('mongo data types', () => {
 
     expect(sqliteValue[2]).toMatchObject({
       _id: 3n,
-      date: '["2023-03-06 13:47:00.000Z"]'
+      date: ['2023-03-06 13:47:00.000Z']
     });
 
     expect(sqliteValue[3]).toMatchObject({

packages/sync-rules/src/types/custom_sqlite_type.ts

@@ -1,7 +1,7 @@
 import { JSONBig } from '@powersync/service-jsonbig';
 import { CompatibilityContext } from '../quirks.js';
 import { SqliteValue, EvaluatedRow, SqliteInputValue, DatabaseInputValue } from '../types.js';
-import { filterJsonData } from '../utils.js';
+import { SqliteValueType } from '../ExpressionType.js';
 
 /**
  * A value that decays into a {@link SqliteValue} in a context-specific way.
@@ -23,14 +23,16 @@ export abstract class CustomSqliteType {
    */
   abstract toSqliteValue(context: CompatibilityContext): SqliteValue;
 
+  abstract get sqliteType(): SqliteValueType;
+
   static wrapArray(elements: DatabaseInputValue[]): SqliteInputValue {
     const hasCustomValue = elements.some((v) => v instanceof CustomSqliteType);
     if (hasCustomValue) {
       // We need access to the compatibility context before encoding contents as JSON.
       return new CustomArray(elements);
     } else {
       // We can encode the array statically.
-      return JSONBig.stringify(elements.map((element) => filterJsonData(element)));
+      return JSONBig.stringify(elements);
     }
   }
 }
@@ -40,11 +42,14 @@ class CustomArray extends CustomSqliteType {
     super();
   }
 
+  get sqliteType(): SqliteValueType {
+    return 'text';
+  }
+
   toSqliteValue(context: CompatibilityContext): SqliteValue {
     return JSONBig.stringify(
       this.elements.map((element) => {
-        const mapped = element instanceof CustomSqliteType ? element.toSqliteValue(context) : element;
-        return filterJsonData(mapped);
+        return element instanceof CustomSqliteType ? element.toSqliteValue(context) : element;
       })
     );
   }

packages/sync-rules/src/types/time.ts

@@ -29,6 +29,10 @@ export class DateTimeValue extends CustomSqliteValue {
     return 'text';
   }
 
+  get sqliteType(): SqliteValueType {
+    return 'text';
+  }
+
   toSqliteValue(context: CompatibilityContext) {
     return context.isEnabled(CompatibilityOption.timestampsIso8601)
       ? this.iso8601Representation