Some cleanup

Author: Rentacookie

modules/module-mysql/src/replication/BinLogStream.ts

@@ -313,7 +313,6 @@ AND table_type = 'BASE TABLE';`,
             afterReplicaId: getUuidReplicaIdentityBson(record, table.replicaIdColumns)
           });
           connection.resume();
-          // TODO: These metrics can probably be reported in batches
           Metrics.getInstance().rows_replicated_total.add(1);
         })
         .on('end', async function () {
@@ -404,7 +403,6 @@ AND table_type = 'BASE TABLE';`,
                 binLogPositionState.offset = evt.position;
                 break;
               case zongji_utils.eventIsWriteMutation(evt):
-                // TODO, can multiple tables be present?
                 const writeTableInfo = evt.tableMap[evt.tableId];
                 await this.writeChanges(batch, {
                   type: storage.SaveOperationTag.INSERT,
@@ -422,7 +420,6 @@ AND table_type = 'BASE TABLE';`,
                 });
                 break;
               case zongji_utils.eventIsDeleteMutation(evt):
-                // TODO, can multiple tables be present?
                 const deleteTableInfo = evt.tableMap[evt.tableId];
                 await this.writeChanges(batch, {
                   type: storage.SaveOperationTag.DELETE,

modules/module-mysql/src/replication/zongji/zongji.d.ts

@@ -55,10 +55,10 @@ declare module '@powersync/mysql-zongji' {
   };
 
   export type TableMapEntry = {
-    columnSchemas: Array<ColumnSchema>;
+    columnSchemas: ColumnSchema[];
     parentSchema: string;
     tableName: string;
-    columns: Array<ColumnDefinition>;
+    columns: ColumnDefinition[];
   };
 
   export type BaseBinLogEvent = {
@@ -96,14 +96,14 @@ declare module '@powersync/mysql-zongji' {
     tableId: number;
     numberOfColumns: number;
     tableMap: Record<string, TableMapEntry>;
-    rows: Array<Record<string, any>>;
+    rows: Record<string, any>[];
   };
 
   export type BinLogUpdateEvent = Omit<BinLogMutationEvent, 'rows'> & {
-    rows: Array<{
+    rows: {
       before: Record<string, any>;
       after: Record<string, any>;
-    }>;
+    }[];
   };
 
   export type BinLogEvent = BinLogRotationEvent | BinLogGTIDLogEvent | BinLogXidEvent | BinLogMutationEvent;

modules/module-mysql/src/utils/mysql_utils.ts

@@ -40,15 +40,13 @@ export function createPool(config: types.NormalizedMySQLConnectionConfig, option
     cert: config.client_certificate
   };
   const hasSSLOptions = Object.values(sslOptions).some((v) => !!v);
-  // TODO confirm if default options are fine for Powersync use case
   return mysql.createPool({
     host: config.hostname,
     user: config.username,
     password: config.password,
     database: config.database,
     ssl: hasSSLOptions ? sslOptions : undefined,
     supportBigNumbers: true,
-    // dateStrings: true,
     timezone: 'Z', // Ensure no auto timezone manipulation of the dates occur
     ...(options || {})
   });