Test consistency of compact.

Author: rkistner

modules/module-mongodb-storage/src/storage/implementation/MongoParameterCompactor.ts

@@ -64,6 +64,7 @@ export class MongoParameterCompactor {
         }
         const rawDoc: RawParameterData = {
           _id: doc._id,
+          // Serializing to a Buffer is an easy way to check for exact equality of arbitrary BSON values.
           data: bson.serialize({
             key: doc.key,
             lookup: doc.lookup

modules/module-mongodb-storage/src/storage/implementation/MongoSyncBucketStorage.ts

@@ -276,7 +276,7 @@ export class MongoSyncBucketStorage
       // This is a roundabout way of setting {readConcern: {atClusterTime: clusterTime}}, since
       // that is not exposed directly by the driver.
       // Future versions of the driver may change the snapshotTime behavior, so we need tests to
-      // validate that this works as expected.
+      // validate that this works as expected. We test this in the compacting tests.
       setSessionSnapshotTime(session, checkpoint.clusterTime.clusterTime);
       const lookupFilter = lookups.map((lookup) => {
         return storage.serializeLookup(lookup);

packages/service-core-tests/src/tests/register-compacting-tests.ts

@@ -1,6 +1,7 @@
 import { storage } from '@powersync/service-core';
 import { expect, test } from 'vitest';
 import * as test_utils from '../test-utils/test-utils-index.js';
+import { ParameterLookup } from '@powersync/service-sync-rules';
 
 const TEST_TABLE = test_utils.makeTestTable('test', ['id']);
 
@@ -442,4 +443,80 @@ bucket_definitions:
       ])
     );
   });
+
+  test('compacting parameters', async () => {
+    await using factory = await generateStorageFactory();
+    const syncRules = await factory.updateSyncRules({
+      content: `
+bucket_definitions:
+  test:
+    parameters: select id from test where id = request.user_id()
+    data: []
+    `
+    });
+    const bucketStorage = factory.getInstance(syncRules);
+
+    await bucketStorage.startBatch(test_utils.BATCH_OPTIONS, async (batch) => {
+      await batch.save({
+        sourceTable: TEST_TABLE,
+        tag: storage.SaveOperationTag.INSERT,
+        after: {
+          id: 't1'
+        },
+        afterReplicaId: 't1'
+      });
+
+      await batch.save({
+        sourceTable: TEST_TABLE,
+        tag: storage.SaveOperationTag.INSERT,
+        after: {
+          id: 't2'
+        },
+        afterReplicaId: 't2'
+      });
+
+      await batch.commit('1/1');
+    });
+
+    const lookup = ParameterLookup.normalized('test', '1', ['t1']);
+
+    const checkpoint1 = await bucketStorage.getCheckpoint();
+    const parameters1 = await checkpoint1.getParameterSets([lookup]);
+    expect(parameters1).toEqual([{ id: 't1' }]);
+
+    await bucketStorage.startBatch(test_utils.BATCH_OPTIONS, async (batch) => {
+      await batch.save({
+        sourceTable: TEST_TABLE,
+        tag: storage.SaveOperationTag.UPDATE,
+        before: {
+          id: 't1'
+        },
+        beforeReplicaId: 't1',
+        after: {
+          id: 't1'
+        },
+        afterReplicaId: 't1'
+      });
+
+      await batch.save({
+        sourceTable: TEST_TABLE,
+        tag: storage.SaveOperationTag.DELETE,
+        before: {
+          id: 't1'
+        },
+        beforeReplicaId: 't1'
+      });
+      await batch.commit('1/2');
+    });
+    const checkpoint2 = await bucketStorage.getCheckpoint();
+    const parameters2 = await checkpoint2.getParameterSets([lookup]);
+    expect(parameters2).toEqual([]);
+
+    await bucketStorage.compact({ compactParameterData: true });
+
+    const parameters1b = await checkpoint1.getParameterSets([lookup]);
+    const parameters2b = await checkpoint2.getParameterSets([lookup]);
+    expect(parameters1b).toEqual([{ id: 't1' }]);
+    expect(parameters2b).toEqual([]);
+  });
 }