Fix passing JSON parameters

Author: simolus3

packages/jpgwire/src/util.ts

@@ -258,8 +258,8 @@ export function timestamptzToSqlite(source?: string): TimeValue | null {
     return null;
   }
 
-  const baseValue = parsed.toISOString().replace('.000', '').replace('Z', '');
-  const baseText = `${baseValue}${precision ?? ''}Z`;
+  const baseValue = parsed.toISOString().replace('Z', '');
+  const baseText = `${baseValue}Z`;
 
   return new TimeValue(baseText);
 }

packages/sync-rules/src/types.ts

@@ -8,6 +8,7 @@ import { BucketPriority } from './BucketDescription.js';
 import { ParameterLookup } from './BucketParameterQuerier.js';
 import { TimeValue } from './types/time.js';
 import { CustomSqliteValue } from './types/custom_sqlite_value.js';
+import { CompatibilityContext } from './quirks.js';
 
 export interface SyncRules {
   evaluateRow(options: EvaluateRowOptions): EvaluationResult[];
@@ -146,12 +147,14 @@ export class RequestParameters implements ParameterValueSet {
       user_id: tokenPayload.sub
     };
 
-    this.tokenParameters = toSyncRulesParameters(tokenParameters);
+    // Client and token parameters don't contain DateTime values or other custom types, so we don't need to consider
+    // compatibility.
+    this.tokenParameters = toSyncRulesParameters(tokenParameters, CompatibilityContext.FULL_BACKWARDS_COMPATIBILITY);
     this.userId = tokenPayload.sub;
     this.rawTokenPayload = JSONBig.stringify(tokenPayload);
 
     this.rawUserParameters = JSONBig.stringify(clientParameters);
-    this.userParameters = toSyncRulesParameters(clientParameters!);
+    this.userParameters = toSyncRulesParameters(clientParameters!, CompatibilityContext.FULL_BACKWARDS_COMPATIBILITY);
     this.streamParameters = null;
     this.rawStreamParameters = null;
   }

packages/sync-rules/src/utils.ts

@@ -123,10 +123,10 @@ export function toSyncRulesRow(row: DatabaseInputRow): SqliteInputRow {
  *
  * @param parameters Generic JSON input
  */
-export function toSyncRulesParameters(parameters: Record<string, any>): SqliteJsonRow {
+export function toSyncRulesParameters(parameters: Record<string, any>, context: CompatibilityContext): SqliteJsonRow {
   let record: SqliteJsonRow = {};
   for (let key of Object.keys(parameters)) {
-    record[key] = toSyncRulesValue(parameters[key], true, false) as SqliteJsonValue;
+    record[key] = applyValueContext(toSyncRulesValue(parameters[key], true, false), context) as SqliteJsonValue;
   }
   return record;
 }