should logout unset sharedprefs['id'] ?

[Dieterbe]

we set sharedprefs['id'] when we log in, and we check sharedprefs['id'] when we check isLoggedIn().

it seems that logout() only manipulates data in sqlite and does not unset sharedprefs['id'] . should it?

[rkistner]

Which logout() method are you referring to here?

The core SDK only handles the data in SQLite via disconnectAndClear(), and the application is responsible for anything else like SharedPreferences.

In our demo apps we typically have something like this:

Future<void> logout() async {
  await Supabase.instance.client.auth.signOut();
  await db.disconnectAndClear();
}

[Dieterbe]

yeah i'm referring to the django-todolist demo

Future<void> logout() async {
  await db.disconnectAndClear();
}

ok if it's the app's responsability, then i guess my question becomes, should the app unset it? right now it just calls await logout(); and then navigates to LoginPage().

i didn't dig too deep into this, but it seems that that this leaves the credentials in place (in sharedprefs), and therefore calls such as isloggedIn() and getUserId() would still act as if we're still logged into. it just looks like it's hidden because we take the user to the loginpage.

[rkistner]

Ok, that's a bug in the django-todolist demo - the logout method should clear SharedPreferences there to properly log out.

[DominicGBauer]

Hi @Dieterbe this has been fixed in #180 thanks for highlighting this