Fix drift migrations #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
previously approved these changes
Nov 6, 2024
stevensJourney
approved these changes
Nov 6, 2024
dfdgsdfg
pushed a commit
to dfdgsdfg/sqlite_async.dart
that referenced
this pull request
Nov 6, 2024
…ions Fix drift migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
drift_sqlite_asyncto run Drift migrations if specified.The issue is that
driftonly runs migrations while opening the database. Part of that is skipping the migrations ifisOpenis true, but we always hadisOpen = trueimmediately.This now changes the behavior to only have
isOpen = trueafteropen()is called, which fixes the migrations.Fixes #76.
This also removes the alpha tag for drift_sqlite_async, to release version 0.2.0.