Update package:sqlite3, migrate to new interop APIs
#81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
changed the title
package:sqlite3, migrate to new interop APIs
rkistner
previously approved these changes
Jan 21, 2025
stevensJourney
previously approved these changes
Jan 21, 2025
simolus3
dismissed stale reviews from stevensJourney and rkistner
via
31d6b56
rkistner
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
package:sqlite3andpackage:sqlite3_web. This changes:sqlite3package now provides commit and rollback notifications. That causes compilation errors in ourThrottledDatabasewrapper. That's not a huge problem because that class is only imported in workers (which we provide for users) and existing compiled workers are compatible with the updatedsqlite3package. This PR adds the missing methods.sqlite3_webadded support for accessing databases in the same context (so without a worker). To support this insqlite3_async(and later the PowerSync SDK as well), theAsyncSqliteControllernow needs to be injected when openingWebSqlite(previously, the controller was only part of the worker).package:powersync_coreto inject its own controller (since the same thing applies - previously this was only part of the db worker, now we might also need it in the main context).