Fix getCases() for S3

Signed-off-by: Etienne Homer <etiennehomer@gmail.com>

Author: etiennehomer

src/main/java/com/powsybl/caseserver/service/FsCaseService.java

@@ -100,7 +100,7 @@ String getFormat(Path caseFile) {
     public List<CaseInfos> getCases() {
         try (Stream<Path> walk = Files.walk(getStorageRootDir())) {
             return walk.filter(Files::isRegularFile)
-                    .map(this::getCaseInfosOrNull)
+                    .map(this::getCaseInfoSafely)
                     .filter(Objects::nonNull)
                     .toList();
         } catch (IOException e) {
@@ -113,7 +113,7 @@ private CaseInfos getCaseInfos(Path file) {
         return removeGzipExtensionFromPlainFile(caseInfos);
     }
 
-    private CaseInfos getCaseInfosOrNull(Path file) {
+    private CaseInfos getCaseInfoSafely(Path file) {
         Objects.requireNonNull(file);
         try {
             return getCaseInfos(file);

src/main/java/com/powsybl/caseserver/service/S3CaseService.java

@@ -270,14 +270,25 @@ public List<CaseInfos> getCases() {
         List<CaseInfos> caseInfosList = new ArrayList<>();
         CaseInfos caseInfos;
         for (S3Object o : getCaseS3Objects(rootDirectory + DELIMITER)) {
-            caseInfos = getCaseInfos(parseUuidFromKey(o.key()));
+            caseInfos = getCaseInfoSafely(parseUuidFromKey(o.key()));
             if (Objects.nonNull(caseInfos)) {
                 caseInfosList.add(caseInfos);
             }
         }
         return caseInfosList;
     }
 
+    private CaseInfos getCaseInfoSafely(UUID uuid) {
+        Objects.requireNonNull(uuid);
+        try {
+            return getCaseInfos(uuid);
+        } catch (Exception e) {
+            // This method is called by getCases() that is a method for supervision and administration. We do not want the request to stop and fail on error cases.
+            LOGGER.error("Error processing case with uuid {}: {}", uuid, e.getMessage(), e);
+            return null;
+        }
+    }
+
     @Override
     public boolean caseExists(UUID uuid) {
         return !getCaseS3Objects(uuid).isEmpty();