[3618] Allow invalid voltageRegulation (TODO add VoltageRegulation validation)

Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>

Author: MatthieuSAUR

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/GeneratorAdderImpl.java

@@ -177,18 +177,16 @@ private VoltageRegulation createVoltageRegulation() {
             .setNetwork(getNetworkRef())
             .setTerminal(this.regulatingTerminal);
         // VOLTAGE case
-        if (Boolean.TRUE.equals(this.voltageRegulatorOn) && !Double.isNaN(this.targetV)) {
+        if (Boolean.TRUE.equals(this.voltageRegulatorOn)) {
             builder.setRegulating(true)
                 .setMode(RegulationMode.VOLTAGE)
                 .setTargetValue(this.targetV);
-//            this.targetV = Double.NaN;
             return builder.build();
             // REACTIVE Power case
         } else if (!Double.isNaN(this.targetQ)) {
             builder.setRegulating(true)
                 .setMode(RegulationMode.REACTIVE_POWER)
                 .setTargetValue(this.targetQ);
-//            this.targetQ = Double.NaN;
             return builder.build();
         }
         return null;

iidm/iidm-serde/src/test/java/com/powsybl/iidm/serde/NetworkSerDeTest.java

@@ -22,7 +22,6 @@
 import com.powsybl.iidm.network.test.*;
 import com.powsybl.iidm.serde.extensions.util.NetworkSourceExtension;
 import com.powsybl.iidm.serde.extensions.util.NetworkSourceExtensionImpl;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.EnumSource;
@@ -228,7 +227,6 @@ void busBreakerExtensions() throws IOException {
     }
 
     @Test
-    @Disabled("TODO MSA inconsistency between targetV/Q null and VoltageRegulatorOn = true")
     void testScada() throws IOException {
         Network network = ScadaNetworkFactory.create();
         assertEquals(ValidationLevel.EQUIPMENT, network.runValidationChecks(false));

iidm/iidm-serde/src/test/resources/V1_16/scadaNetwork.xml

@@ -10,6 +10,7 @@
                     <iidm:point p="0.0" minQ="0.0" maxQ="0.0"/>
                     <iidm:point p="10.0" minQ="5.0" maxQ="15.0"/>
                 </iidm:reactiveCapabilityCurve>
+                <iidm:voltageRegulation regulating="true" mode="VOLTAGE"/>
             </iidm:generator>
             <iidm:battery id="battery" minP="0.0" maxP="100.0" bus="bus" connectableBus="bus">
                 <iidm:minMaxReactiveLimits minQ="-1.7976931348623157E308" maxQ="1.7976931348623157E308"/>