improve SVC validation rules wip

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

Author: samirromdhani

loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/StaticVarCompensatorsValidation.java

@@ -25,6 +25,9 @@
 import com.powsybl.iidm.network.StaticVarCompensator.RegulationMode;
 import com.powsybl.loadflow.validation.io.ValidationWriter;
 
+import static com.powsybl.loadflow.validation.ValidationUtils.isOutsideTolerance;
+import static com.powsybl.loadflow.validation.ValidationUtils.isUndefinedOrZero;
+
 /**
  *
  * @author Massimo Ferraro {@literal <massimo.ferraro@techrain.eu>}
@@ -164,7 +167,8 @@ public boolean checkSVCs(String id, double p, double q, double vControlled, doub
 
     private static boolean checkSVCsNaNValues(String id, double p, double q, double reactivePowerSetpoint) {
         // a validation error should be detected if there is a setpoint but no p or q
-        if (!Double.isNaN(reactivePowerSetpoint) && reactivePowerSetpoint != 0) {
+        // Rule2: reactivePowerSetpoint must be undefined or equal to 0 when no p or q
+        if (!isUndefinedOrZero(reactivePowerSetpoint, 0.0)) {
             LOGGER.warn("{} {}: {}: P={} Q={} reactivePowerSetpoint={}", ValidationType.SVCS, ValidationUtils.VALIDATION_ERROR, id, p, q, reactivePowerSetpoint);
             return false;
         }
@@ -175,8 +179,9 @@ private static boolean checkSVCsValues(String id, double p, double q, double vCo
         double nominalVcontroller, double reactivePowerSetpoint, double voltageSetpoint,
         RegulationMode regulationMode, boolean regulating, double bMin, double bMax, ValidationConfig config) {
         boolean validated = true;
+        double threshold = config.getThreshold();
         // Rule1: active power should be equal to 0
-        if (Math.abs(p) > config.getThreshold()) {
+        if (isOutsideTolerance(p, 0.0, threshold)) {
             LOGGER.warn("{} {}: {}: P={}", ValidationType.SVCS, ValidationUtils.VALIDATION_ERROR, id, p);
             validated = false;
         }