refactor(loadflow-validation): remove duplicated code

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

Author: samirromdhani

loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/GeneratorsValidation.java

@@ -19,7 +19,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import com.powsybl.iidm.network.Bus;
 import com.powsybl.iidm.network.Generator;
 import com.powsybl.iidm.network.Network;
 import com.powsybl.loadflow.validation.io.ValidationWriter;
@@ -89,7 +88,6 @@ public boolean checkGenerators(Generator gen, ValidationConfig config, Validatio
         Objects.requireNonNull(generatorsWriter);
         double p = gen.getTerminal().getP();
         double q = gen.getTerminal().getQ();
-        Bus bus = gen.getTerminal().getBusView().getBus();
         double targetP = gen.getTargetP();
         double targetQ = gen.getTargetQ();
         double targetV = gen.getTargetV();
@@ -98,11 +96,10 @@ public boolean checkGenerators(Generator gen, ValidationConfig config, Validatio
         double maxP = gen.getMaxP();
         double minQ = gen.getReactiveLimits().getMinQ(targetP);
         double maxQ = gen.getReactiveLimits().getMaxQ(targetP);
-        double v = bus != null ? bus.getV() : Double.NaN;
-        boolean connected = bus != null;
-        Bus connectableBus = gen.getTerminal().getBusView().getConnectableBus();
-        boolean connectableMainComponent = connectableBus != null && connectableBus.isInMainConnectedComponent();
-        boolean mainComponent = bus != null ? bus.isInMainConnectedComponent() : connectableMainComponent;
+        ValidationUtils.TerminalState terminalState = ValidationUtils.getTerminalState(gen.getTerminal());
+        double v = terminalState.v();
+        boolean connected = terminalState.connected();
+        boolean mainComponent = terminalState.mainComponent();
         return checkGenerators(gen.getId(), p, q, v, targetP, targetQ, targetV, voltageRegulatorOn, minP, maxP, minQ, maxQ, connected,
                                mainComponent, config, generatorsWriter, guesser);
     }

loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/ShuntCompensatorsValidation.java

@@ -96,12 +96,10 @@ public boolean checkShunts(ShuntCompensator shunt, ValidationConfig config, Vali
         double bPerSection = shunt.getModel(ShuntCompensatorLinearModel.class).getBPerSection();
         double nominalV = shunt.getTerminal().getVoltageLevel().getNominalV();
         double qMax = bPerSection * maximumSectionCount * nominalV * nominalV;
-        Bus bus = shunt.getTerminal().getBusView().getBus();
-        double v = bus != null ? bus.getV() : Double.NaN;
-        boolean connected = bus != null;
-        Bus connectableBus = shunt.getTerminal().getBusView().getConnectableBus();
-        boolean connectableMainComponent = connectableBus != null && connectableBus.isInMainConnectedComponent();
-        boolean mainComponent = bus != null ? bus.isInMainConnectedComponent() : connectableMainComponent;
+        ValidationUtils.TerminalState terminalState = ValidationUtils.getTerminalState(shunt.getTerminal());
+        double v = terminalState.v();
+        boolean connected = terminalState.connected();
+        boolean mainComponent = terminalState.mainComponent();
         return checkShunts(shunt.getId(), p, q, currentSectionCount, maximumSectionCount, bPerSection, v, qMax, nominalV, connected, mainComponent, config, shuntsWriter);
     }
 

loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/StaticVarCompensatorsValidation.java

@@ -97,17 +97,12 @@ public boolean checkSVCs(StaticVarCompensator svc, ValidationConfig config, Vali
         double bMax = svc.getBmax();
         double nominalVcontroller = svc.getTerminal().getVoltageLevel().getNominalV();
         double vController = bus != null ? bus.getV() : Double.NaN;
-        double vControlled;
-        if (svc.getRegulatingTerminal() != null) {
-            Bus controlledBus = svc.getRegulatingTerminal().getBusView().getBus();
-            vControlled = controlledBus != null ? controlledBus.getV() : Double.NaN;
-        } else {
-            vControlled = vController;
-        }
-        boolean connected = bus != null;
-        Bus connectableBus = svc.getTerminal().getBusView().getConnectableBus();
-        boolean connectableMainComponent = connectableBus != null && connectableBus.isInMainConnectedComponent();
-        boolean mainComponent = bus != null ? bus.isInMainConnectedComponent() : connectableMainComponent;
+        double vControlled = svc.getRegulatingTerminal() != null
+                ? ValidationUtils.getTerminalState(svc.getRegulatingTerminal()).v()
+                : vController;
+        ValidationUtils.TerminalState terminalState = ValidationUtils.getTerminalState(svc.getTerminal());
+        boolean connected = terminalState.connected();
+        boolean mainComponent = terminalState.mainComponent();
         return checkSVCs(svc.getId(), p, q, vControlled, vController, nominalVcontroller, reactivePowerSetpoint, voltageSetpoint, regulationMode, regulating, bMin, bMax, connected, mainComponent, config, svcsWriter);
     }
 

loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/TransformersValidation.java

@@ -97,12 +97,11 @@ public boolean checkTransformer(TwoWindingsTransformer twt, ValidationConfig con
             }
             return true;
         }
-        Bus bus = ratioTapChanger.getRegulationTerminal().getBusView().getBus();
-        double v = bus != null ? bus.getV() : Double.NaN;
-        boolean connected = bus != null;
-        Bus connectableBus = ratioTapChanger.getRegulationTerminal().getBusView().getConnectableBus();
-        boolean connectableMainComponent = connectableBus != null && connectableBus.isInMainConnectedComponent();
-        boolean mainComponent = bus != null ? bus.isInMainConnectedComponent() : connectableMainComponent;
+        ValidationUtils.TerminalState terminalState = ValidationUtils.getTerminalState(ratioTapChanger.getRegulationTerminal());
+        double v = terminalState.v();
+        boolean connected = terminalState.connected();
+        boolean mainComponent = terminalState.mainComponent();
+
         return checkTransformer(twt.getId(), rho, rhoPreviousStep, rhoNextStep, tapPosition, lowTapPosition, highTapPosition,
                                  targetV, regulatedSide, v, connected, mainComponent, config, twtsWriter);
     }

loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/ValidationUtils.java

@@ -8,6 +8,8 @@
 package com.powsybl.loadflow.validation;
 
 import com.powsybl.commons.config.ConfigurationException;
+import com.powsybl.iidm.network.Bus;
+import com.powsybl.iidm.network.Terminal;
 import com.powsybl.loadflow.validation.io.ValidationWriter;
 import com.powsybl.loadflow.validation.io.ValidationWriterFactory;
 
@@ -89,4 +91,17 @@ public static boolean isMainComponent(ValidationConfig config, boolean mainCompo
         return !config.isCheckMainComponentOnly() || mainComponent;
     }
 
+    public record TerminalState(double v, boolean connected, boolean mainComponent) { }
+
+    public static TerminalState getTerminalState(Terminal terminal) {
+        Objects.requireNonNull(terminal);
+        Bus bus = terminal.getBusView().getBus();
+        Bus connectableBus = terminal.getBusView().getConnectableBus();
+        boolean connected = bus != null;
+        boolean connectableMainComponent = connectableBus != null && connectableBus.isInMainConnectedComponent();
+        boolean mainComponent = connected ? bus.isInMainConnectedComponent() : connectableMainComponent;
+        double v = connected ? bus.getV() : Double.NaN;
+        return new TerminalState(v, connected, mainComponent);
+    }
+
 }