Clean usage of matrixCopyValues in DC Sensitivity Analysis (#1198)

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

Author: p-arvy

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

@@ -13,7 +13,6 @@
 import com.powsybl.iidm.network.Network;
 import com.powsybl.loadflow.LoadFlowParameters;
 import com.powsybl.math.matrix.DenseMatrix;
-import com.powsybl.math.matrix.MatrixException;
 import com.powsybl.math.matrix.MatrixFactory;
 import com.powsybl.openloadflow.OpenLoadFlowParameters;
 import com.powsybl.openloadflow.dc.DcLoadFlowContext;
@@ -475,8 +474,8 @@ public void analyse(Network network, List<PropagatedContingency> contingencies,
 
                 // process contingencies with no connectivity break
                 for (PropagatedContingency contingency : connectivityBreakAnalysisResults.nonBreakingConnectivityContingencies()) {
-                    matrixCopyValues(baseFlowStates, workingFlowStates);
-                    matrixCopyValues(baseFactorStates, workingFactorStates);
+                    workingFlowStates.copyValuesFrom(baseFlowStates);
+                    workingFactorStates.copyValuesFrom(baseFactorStates);
 
                     calculateSensitivityValuesForAContingency(loadFlowContext, lfParametersExt, validFactorHolder, factorGroups,
                             workingFactorStates, connectivityBreakAnalysisResults.contingenciesStates(), workingFlowStates, contingency,
@@ -487,8 +486,8 @@ public void analyse(Network network, List<PropagatedContingency> contingencies,
 
                 // process contingencies with connectivity break
                 for (ConnectivityBreakAnalysis.ConnectivityAnalysisResult connectivityAnalysisResult : connectivityBreakAnalysisResults.connectivityAnalysisResults()) {
-                    matrixCopyValues(baseFlowStates, workingFlowStates);
-                    matrixCopyValues(baseFactorStates, workingFactorStates);
+                    workingFlowStates.copyValuesFrom(baseFlowStates);
+                    workingFactorStates.copyValuesFrom(baseFactorStates);
 
                     processContingenciesBreakingConnectivity(connectivityAnalysisResult, loadFlowContext, lfParameters, lfParametersExt,
                             validFactorHolder, factorGroups, participatingElements, connectivityBreakAnalysisResults.contingencyElementByBranch(),
@@ -501,21 +500,4 @@ public void analyse(Network network, List<PropagatedContingency> contingencies,
         }
     }
 
-    /**
-     * Copy all the values that are in an originalMatrix and paste it in the copyMatrix (without allocating new memory spaces)
-     * The dimensions of both matrices must be the same
-     */
-    // TODO : implement this method for DenseMatrix in powsybl-core ?
-    private static void matrixCopyValues(DenseMatrix originalMatrix, DenseMatrix copyMatrix) {
-        if (originalMatrix.getRowCount() == copyMatrix.getRowCount() && originalMatrix.getColumnCount() == copyMatrix.getColumnCount()) {
-            for (int columnIndex = 0; columnIndex < originalMatrix.getColumnCount(); columnIndex++) {
-                for (int rowIndex = 0; rowIndex < originalMatrix.getRowCount(); rowIndex++) {
-                    copyMatrix.set(rowIndex, columnIndex, originalMatrix.get(rowIndex, columnIndex));
-                }
-            }
-        } else {
-            throw new MatrixException("Incompatible matrices dimensions when copying values. Received (" + originalMatrix.getRowCount() + ", " + originalMatrix.getColumnCount() + ") and (" + copyMatrix.getRowCount() + ", " + copyMatrix.getColumnCount() + ")");
-        }
-    }
-
 }