Skip to content

Commit 0c11048

Browse files
committed
Review changes: add test for string arg + kwargs.
1 parent 811168b commit 0c11048

File tree

1 file changed

+18
-7
lines changed

1 file changed

+18
-7
lines changed

lib/iris/tests/unit/combine/test_CombineOptions.py

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -141,20 +141,31 @@ def test_kwargs(self, op_is_set):
141141
op_is_set=op_is_set,
142142
)
143143

144-
def test_arg_kwargs(self, op_is_set):
145-
# Show that kwargs override arg
146-
initial_options = CombineOptions(
147-
merge_concat_sequence="m",
148-
repeat_until_unchanged=False,
149-
)
144+
def test_arg_dict_plus_kwargs(self, op_is_set):
145+
# Show that kwargs override dictionary arg
150146
expect_before = {"merge_concat_sequence": "m", "repeat_until_unchanged": False}
151147
# NOTE: the arg changes the sequence from "m" to "c" ...
152148
set_arg = dict(merge_concat_sequence="c", repeat_until_unchanged=True)
153149
# .. but the keyword overrides that to "mc"
154150
set_kwargs = dict(merge_concat_sequence="mc")
155151
expect_after = {"merge_concat_sequence": "mc", "repeat_until_unchanged": True}
156152
self.do_check(
157-
initial_options=initial_options,
153+
before_checks=expect_before,
154+
op_arg=set_arg,
155+
op_kwargs=set_kwargs,
156+
after_checks=expect_after,
157+
op_is_set=op_is_set,
158+
)
159+
160+
def test_arg_str_plus_kwargs(self, op_is_set):
161+
# Show that kwargs override settings-name arg
162+
expect_before = {"merge_concat_sequence": "m", "repeat_until_unchanged": False}
163+
# NOTE: the arg changes 'sequence' to "mc", and 'repeat' to True ...
164+
set_arg = "comprehensive"
165+
# .. but the keyword overrides 'repeat' to False again
166+
set_kwargs = dict(repeat_until_unchanged=False)
167+
expect_after = {"merge_concat_sequence": "mc", "repeat_until_unchanged": False}
168+
self.do_check(
158169
before_checks=expect_before,
159170
op_arg=set_arg,
160171
op_kwargs=set_kwargs,

0 commit comments

Comments
 (0)