Merge pull request #6691 from Susko3/fix-zero-displays-crashing-game

Fix game crashing when no displays are connected

Author: peppy

osu.Framework/Platform/SDL2/SDL2Window_Windowing.cs

@@ -302,8 +302,18 @@ public WindowState WindowState
         /// </remarks>
         private void fetchDisplays()
         {
-            Displays = getSDLDisplays();
-            DisplaysChanged?.Invoke(Displays);
+            var newDisplays = getSDLDisplays();
+
+            if (newDisplays.Length > 0)
+            {
+                Displays = newDisplays;
+                DisplaysChanged?.Invoke(newDisplays);
+            }
+            else
+            {
+                // keep Displays stale if zero displays are currently detected
+                Logger.Log("Got zero displays from SDL, ignoring.");
+            }
         }
 
         /// <summary>
@@ -328,7 +338,7 @@ private static ImmutableArray<Display> getSDLDisplays()
         {
             int numDisplays = SDL_GetNumVideoDisplays();
 
-            if (numDisplays <= 0)
+            if (numDisplays < 0)
                 throw new InvalidOperationException($"Failed to get number of SDL displays. Return code: {numDisplays}. SDL Error: {SDL_GetError()}");
 
             var builder = ImmutableArray.CreateBuilder<Display>(numDisplays);

osu.Framework/Platform/SDL3/SDL3Window_Windowing.cs

@@ -306,8 +306,18 @@ public WindowState WindowState
         /// </remarks>
         private void fetchDisplays()
         {
-            Displays = getSDLDisplays();
-            DisplaysChanged?.Invoke(Displays);
+            var newDisplays = getSDLDisplays();
+
+            if (newDisplays.Length > 0)
+            {
+                Displays = newDisplays;
+                DisplaysChanged?.Invoke(newDisplays);
+            }
+            else
+            {
+                // keep Displays stale if zero displays are currently detected
+                Logger.Log("Got zero displays from SDL, ignoring.");
+            }
         }
 
         /// <summary>