perf: avoid extra allocation

Author: ppzqh

internal/utils/singleflightutil/singleFlight.go

@@ -28,12 +28,12 @@ type Group struct {
 // CheckAndDo implements a double-checked pattern to ensure that `fn` is executed only once for a given key.
 // It performs an initial check with `checkFn` before calling `singleflight.Do`. If the value is found, return.
 // Otherwise, call `Do` and execute `checkFn` again before executing `fn`.
-func (g *Group) CheckAndDo(key string, checkFn func() (any, bool), fn func() (any, error)) (v any, err error, shared bool) {
-	if value, loaded := checkFn(); loaded {
+func (g *Group) CheckAndDo(key string, checkFn func(key string) (any, bool), fn func() (any, error)) (v any, err error, shared bool) {
+	if value, loaded := checkFn(key); loaded {
 		return value, nil, true
 	}
 	return g.Do(key, func() (any, error) {
-		if value, loaded := checkFn(); loaded {
+		if value, loaded := checkFn(key); loaded {
 			return value, nil
 		}
 		return fn()

internal/utils/singleflightutil/singleFlight_test.go

@@ -39,8 +39,8 @@ func TestCheckAndDo(t *testing.T) {
 			return "new", nil
 		}
 
-		checkFunc := func() (any, bool) {
-			return cache.Load(key)
+		checkFunc := func(str string) (any, bool) {
+			return cache.Load(str)
 		}
 
 		val, err, shared := g.CheckAndDo(key, checkFunc, fn)
@@ -61,8 +61,8 @@ func TestCheckAndDo(t *testing.T) {
 			cache.Store(key, curr)
 			return curr, nil
 		}
-		checkFunc := func() (any, bool) {
-			return cache.Load(key)
+		checkFunc := func(str string) (any, bool) {
+			return cache.Load(str)
 		}
 
 		var wg sync.WaitGroup

pkg/loadbalance/consist.go

@@ -248,8 +248,8 @@ func (cb *consistBalancer) GetPicker(e discovery.Result) Picker {
 	if e.Cacheable {
 		cii, _, _ := cb.sfg.CheckAndDo(
 			e.CacheKey,
-			func() (any, bool) {
-				return cb.cachedConsistInfo.Load(e.CacheKey)
+			func(key string) (any, bool) {
+				return cb.cachedConsistInfo.Load(key)
 			},
 			func() (interface{}, error) {
 				res := cb.newConsistInfo(e)

pkg/loadbalance/lbcache/cache.go

@@ -120,8 +120,8 @@ func NewBalancerFactory(resolver discovery.Resolver, balancer loadbalance.Loadba
 	}
 	uniqueKey := cacheKey(resolver.Name(), balancer.Name(), opts)
 	val, _, _ := balancerFactoriesSfg.CheckAndDo(uniqueKey,
-		func() (any, bool) {
-			return balancerFactories.Load(uniqueKey)
+		func(key string) (any, bool) {
+			return balancerFactories.Load(key)
 		},
 		func() (interface{}, error) {
 			b := newBalancerFactory(resolver, balancer, opts)
@@ -158,8 +158,8 @@ func renameResultCacheKey(res *discovery.Result, resolverName string) {
 func (b *BalancerFactory) Get(ctx context.Context, target rpcinfo.EndpointInfo) (*Balancer, error) {
 	desc := b.resolver.Target(ctx, target)
 	val, err, _ := b.sfg.CheckAndDo(desc,
-		func() (any, bool) {
-			return b.cache.Load(desc)
+		func(key string) (any, bool) {
+			return b.cache.Load(key)
 		},
 		func() (interface{}, error) {
 			res, err := b.resolver.Resolve(ctx, desc)

pkg/loadbalance/lbcache/shared_ticker.go

@@ -33,8 +33,8 @@ var (
 func getSharedTicker(b *Balancer, refreshInterval time.Duration) *utils.SharedTicker {
 	v, _, _ := sharedTickersSfg.CheckAndDo(
 		refreshInterval.String(),
-		func() (any, bool) {
-			return sharedTickers.Load(refreshInterval)
+		func(key string) (any, bool) {
+			return sharedTickers.Load(key)
 		},
 		func() (interface{}, error) {
 			st := utils.NewSharedTicker(refreshInterval)

pkg/loadbalance/weighted_balancer.go

@@ -73,8 +73,8 @@ func (wb *weightedBalancer) GetPicker(e discovery.Result) Picker {
 		return picker
 	}
 	picker, _, _ := wb.sfg.CheckAndDo(e.CacheKey,
-		func() (any, bool) {
-			return wb.pickerCache.Load(e.CacheKey)
+		func(key string) (any, bool) {
+			return wb.pickerCache.Load(key)
 		},
 		func() (interface{}, error) {
 			p := wb.createPicker(e)