Skip to content

Commit 34bc920

Browse files
willieyzmkannwischer
authored andcommitted
CI: Test multiple ACVP versions
- This commit is ported from mlkem-native PR#1119. Previously, the acvp_client.py would test multiple versions of ACVP. This behaviour was changed when switching to on-the-fly downloading of test vectors to only use the most recent ACVP version. This commit adds testing older versions of ACVP in CI as well restoring the previous test coverage. Signed-off-by: willieyz <[email protected]>
1 parent 2b60203 commit 34bc920

File tree

1 file changed

+25
-0
lines changed

1 file changed

+25
-0
lines changed

.github/workflows/base.yml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,31 @@ jobs:
6363
- name: tests func
6464
run: |
6565
./scripts/tests func
66+
quickcheck-acvp:
67+
strategy:
68+
fail-fast: false
69+
matrix:
70+
external:
71+
- ${{ github.repository_owner != 'pq-code-package' }}
72+
target:
73+
- runner: pqcp-arm64
74+
name: 'aarch64'
75+
- runner: ubuntu-latest
76+
name: 'x86_64'
77+
acvp-version: [v1.1.0.38, v1.1.0.39, v1.1.0.40]
78+
exclude:
79+
- {external: true,
80+
target: {
81+
runner: pqcp-arm64,
82+
name: 'aarch64'
83+
}}
84+
name: Quickcheck ACVP (${{ matrix.target.name }}, ${{ matrix.acvp-version }})
85+
runs-on: ${{ matrix.target.runner }}
86+
steps:
87+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
88+
- name: Run ACVP test
89+
run: |
90+
./scripts/tests acvp --version ${{ matrix.acvp-version }}
6691
quickcheck_bench:
6792
strategy:
6893
fail-fast: false

0 commit comments

Comments
 (0)