Skip to content

Commit 5e7bce5

Browse files
committed
Workaround unused citation issue caused by simpasm
Currently, citations within asm can cause linter to complain about unused citation, because comments are not preserved after simpasm. Signed-off-by: jammychiou1 <[email protected]>
1 parent 681048a commit 5e7bce5

File tree

4 files changed

+7
-29
lines changed

4 files changed

+7
-29
lines changed

BIBLIOGRAPHY.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -247,15 +247,6 @@ source code and documentation.
247247
- [mldsa/src/native/aarch64/src/intt.S](mldsa/src/native/aarch64/src/intt.S)
248248
- [mldsa/src/native/aarch64/src/ntt.S](mldsa/src/native/aarch64/src/ntt.S)
249249

250-
### `Survey_Hwang23`
251-
252-
* A Survey of Polynomial Multiplications for Lattice-Based Cryptosystems
253-
* Author(s):
254-
- Vincent Hwang
255-
* URL: https://eprint.iacr.org/2023/1962
256-
* Referenced from:
257-
- [dev/x86_64/src/intt.S](dev/x86_64/src/intt.S)
258-
259250
### `libmceliece`
260251

261252
* libmceliece implementation of Classic McEliece

BIBLIOGRAPHY.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -103,14 +103,6 @@
103103
- Kannwischer, Matthias J.
104104
- Yang, Bo-Yin
105105
- Yang, Shang-Yi
106-
107-
- id: Survey_Hwang23
108-
name: "A Survey of Polynomial Multiplications for Lattice-Based Cryptosystems"
109-
year: 2023
110-
url: https://eprint.iacr.org/2023/1962
111-
author:
112-
- Hwang, Vincent
113-
114106
- id: mupq
115107
name: Common files for pqm4, pqm3, pqriscv
116108
author:

dev/x86_64/src/intt.S

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
* CRYSTALS-Dilithium optimized AVX2 implementation
1616
* Bai, Ducas, Kiltz, Lepoint, Lyubashevsky, Schwabe, Seiler, Stehlé
1717
* https://github.com/pq-crystals/dilithium/tree/master/avx2
18-
*
19-
* - [Survey_Hwang23]
20-
* A Survey of Polynomial Multiplications for Lattice-Based Cryptosystems
21-
* Vincent Hwang
22-
* https://eprint.iacr.org/2023/1962
2318
*/
2419

2520
#include "../../../common.h"
@@ -314,15 +309,20 @@ vpblendd $0xAA,%ymm9,%ymm7,%ymm7
314309
* The bound ceil(3q/4) for this scaling, as well as any other "Montgomery
315310
* multiplication with signed canonical constant", is justified as follows.
316311
*
317-
* In @[Survey_Hwang23, Section 2.2] they showed a bound that works for any
318-
* variable input a, as long as the constant b is signed canonical:
312+
* In Section 2.2 of https://eprint.iacr.org/2023/1962, they showed a bound that
313+
* works for any variable input a, as long as the constant b is signed
314+
* canonical:
319315
*
320316
* |montmul(a, b)| <= (|a| (q/2) + (R/2) q) / R = (q/2) (1 + |a|/R).
321317
*
322318
* Therefore, even if we know nothing about a except that it fits inside
323319
* int32_t (thus |a| <= R/2), we still have |montmul(a, b)| <= 3q/4. This can be
324320
* strengthened to |montmul_pos(a, b)| <= floor(3q/4) < ceil(3q/4) since LHS is
325321
* an integer and 3q/4 isn't.
322+
*
323+
* TODO: Use proper citation. Currently, citations within asm can cause linter
324+
* to complain about unused citation, because comments are not preserved
325+
* after simpasm.
326326
*/
327327

328328
/* 4, 5, 6, 7: abs bound < ceil(3q/4) */

mldsa/src/native/x86_64/src/intt.S

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
* CRYSTALS-Dilithium optimized AVX2 implementation
1616
* Bai, Ducas, Kiltz, Lepoint, Lyubashevsky, Schwabe, Seiler, Stehlé
1717
* https://github.com/pq-crystals/dilithium/tree/master/avx2
18-
*
19-
* - [Survey_Hwang23]
20-
* A Survey of Polynomial Multiplications for Lattice-Based Cryptosystems
21-
* Vincent Hwang
22-
* https://eprint.iacr.org/2023/1962
2318
*/
2419

2520
#include "../../../common.h"

0 commit comments

Comments
 (0)