1. Correct conditional compilation tests to include only functions

   actually called in each build.

2. Add namespacing to mld_compute_sum_of_products() so works
   with the multi-level build.

Signed-off-by: Rod Chapman <[email protected]>

Author: rod-chapman

mldsa/src/poly_kl.c

@@ -468,7 +468,7 @@ void mld_poly_uniform_eta(mld_poly *r, const uint8_t seed[MLDSA_CRHBYTES],
 #define POLY_UNIFORM_GAMMA1_NBLOCKS \
   ((MLDSA_POLYZ_PACKEDBYTES + STREAM256_BLOCKBYTES - 1) / STREAM256_BLOCKBYTES)
 
-#if MLD_CONFIG_PARAMETER_SET == 65
+#if MLD_CONFIG_PARAMETER_SET == 65 || defined(MLD_CONFIG_SERIAL_FIPS202_ONLY)
 MLD_INTERNAL_API
 void mld_poly_uniform_gamma1(mld_poly *a, const uint8_t seed[MLDSA_CRHBYTES],
                              uint16_t nonce)
@@ -495,7 +495,8 @@ void mld_poly_uniform_gamma1(mld_poly *a, const uint8_t seed[MLDSA_CRHBYTES],
   mld_zeroize(buf, sizeof(buf));
   mld_zeroize(extseed, sizeof(extseed));
 }
-#endif /* MLD_CONFIG_PARAMETER_SET == 65 */
+#endif /* MLD_CONFIG_PARAMETER_SET == 65 || \
+          defined(MLD_CONFIG_SERIAL_FIPS202_ONLY) */
 
 
 #if !defined(MLD_CONFIG_SERIAL_FIPS202_ONLY)

mldsa/src/poly_kl.h

@@ -161,7 +161,7 @@ __contract__(
   ensures(array_abs_bound(r3->coeffs, 0, MLDSA_N, MLDSA_ETA + 1))
 );
 
-#if MLD_CONFIG_PARAMETER_SET == 65
+#if defined(MLD_CONFIG_SERIAL_FIPS202_ONLY)
 #define mld_poly_uniform_eta MLD_NAMESPACE_KL(poly_uniform_eta)
 /*************************************************
  * Name:        mld_poly_uniform_eta
@@ -184,8 +184,9 @@ __contract__(
   assigns(memory_slice(r, sizeof(mld_poly)))
   ensures(array_abs_bound(r->coeffs, 0, MLDSA_N, MLDSA_ETA + 1))
 );
+#endif
 
-
+#if MLD_CONFIG_PARAMETER_SET == 65 || defined(MLD_CONFIG_SERIAL_FIPS202_ONLY)
 #define mld_poly_uniform_gamma1 MLD_NAMESPACE_KL(poly_uniform_gamma1)
 /*************************************************
  * Name:        mld_poly_uniform_gamma1
@@ -208,7 +209,8 @@ __contract__(
   assigns(memory_slice(a, sizeof(mld_poly)))
   ensures(array_bound(a->coeffs, 0, MLDSA_N, -(MLDSA_GAMMA1 - 1), MLDSA_GAMMA1 + 1))
 );
-#endif /* MLD_CONFIG_PARAMETER_SET == 65 */
+#endif /* MLD_CONFIG_PARAMETER_SET == 65 || \
+          defined(MLD_CONFIG_SERIAL_FIPS202_ONLY) */
 
 #define mld_poly_uniform_gamma1_4x MLD_NAMESPACE_KL(poly_uniform_gamma1_4x)
 /*************************************************

mldsa/src/polyvec.c

@@ -357,6 +357,8 @@ void mld_polyvecl_pointwise_acc_montgomery(mld_poly *w, const mld_polyvecl *u,
          MLD_USE_NATIVE_POLYVECL_POINTWISE_ACC_MONTGOMERY_L7 &&   \
          MLD_CONFIG_PARAMETER_SET == 87 */
 
+#define mld_pointwise_sum_of_products \
+  MLD_NAMESPACE_KL(mld_pointwise_sum_of_products)
 static int64_t mld_pointwise_sum_of_products(const mld_polyvecl *u,
                                              const mld_polyvecl *v,
                                              unsigned int i)