Fix macro typo: MLK_INTERNAL_API => MLD_INTERNAL_API

- This commit fixes a error cause by macro typo in .clang-format where MLK_INTERNAL_API
should be MLD_INTERNAL_API. This typo was detected after extending the
macro checker to catch wrongly ported MLK_XXX/MLKEM_XXX macros.

- The typo fix causes clang-format to reformat some files (packing.h and
  polyvec.h) by changing macro order from:
    MLD_MUST_CHECK_RETURN_VALUE
    MLD_INTERNAL_API
  to:
    MLD_MUST_CHECK_RETURN_VALUE MLD_INTERNAL_API

- This reordering is the wrong, and it is because the order of these two macor,
  after referece from mlkem-native, we switch the macro order from:
    MLD_MUST_CHECK_RETURN_VALUE
    MLD_INTERNAL_API
  to:
    MLD_INTERNAL_API
    MLD_MUST_CHECK_RETURN_VALUE
  This is correct formatting behavior and matches the mlkem-native convention.

Signed-off-by: willieyz <[email protected]>

Author: willieyz

.clang-format

@@ -25,4 +25,4 @@ Macros:
  - __contract__(x)={ void a; void b; void c; void d; void e; void f; } void abcdefghijklmnopqrstuvw()
  - __loop__(x)={} do
  # Make this artifically long to force line break
- - MLK_INTERNAL_API=void abcdefghijklmnopqrstuvwabcdefghijklmnopqrstuvwabcdefg();
+ - MLD_INTERNAL_API=void abcdefghijklmnopqrstuvwabcdefghijklmnopqrstuvwabcdefg();

mldsa/src/packing.h

@@ -183,8 +183,8 @@ __contract__(
  *
  * Returns 1 in case of malformed signature; otherwise 0.
  **************************************************/
-MLD_MUST_CHECK_RETURN_VALUE
 MLD_INTERNAL_API
+MLD_MUST_CHECK_RETURN_VALUE
 int mld_unpack_sig(uint8_t c[MLDSA_CTILDEBYTES], mld_polyvecl *z,
                    mld_polyveck *h, const uint8_t sig[MLDSA_CRYPTO_BYTES])
 __contract__(

mldsa/src/polyvec.h

@@ -216,8 +216,8 @@ __contract__(
  * Returns 0 if norm of all polynomials is strictly smaller than B <=
  * (MLDSA_Q-1)/8 and 0xFFFFFFFF otherwise.
  **************************************************/
-MLD_MUST_CHECK_RETURN_VALUE
 MLD_INTERNAL_API
+MLD_MUST_CHECK_RETURN_VALUE
 uint32_t mld_polyvecl_chknorm(const mld_polyvecl *v, int32_t B)
 __contract__(
   requires(memory_no_alias(v, sizeof(mld_polyvecl)))
@@ -424,8 +424,8 @@ __contract__(
  * Returns 0 if norm of all polynomials are strictly smaller than B <=
  *(MLDSA_Q-1)/8 and 0xFFFFFFFF otherwise.
  **************************************************/
-MLD_MUST_CHECK_RETURN_VALUE
 MLD_INTERNAL_API
+MLD_MUST_CHECK_RETURN_VALUE
 uint32_t mld_polyveck_chknorm(const mld_polyveck *v, int32_t B)
 __contract__(
   requires(memory_no_alias(v, sizeof(mld_polyveck)))
@@ -514,8 +514,8 @@ __contract__(
  *
  * Returns number of 1 bits.
  **************************************************/
-MLD_MUST_CHECK_RETURN_VALUE
 MLD_INTERNAL_API
+MLD_MUST_CHECK_RETURN_VALUE
 unsigned int mld_polyveck_make_hint(mld_polyveck *h, const mld_polyveck *v0,
                                     const mld_polyveck *v1)
 __contract__(