Skip to content

Commit c32fa10

Browse files
committed
CR fixes
Signed-off-by: Jake Massimo <[email protected]>
1 parent 75ae090 commit c32fa10

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

dev/x86_64/src/ntt.S

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@ vmovdqa %ymm11,256*\off+224(%rdi)
267267
.balign 4
268268
.global MLD_ASM_NAMESPACE(ntt_avx2)
269269
MLD_ASM_FN_SYMBOL(ntt_avx2)
270-
endbr64
271270
vmovdqa MLD_AVX2_BACKEND_DATA_OFFSET_8XQ*4(%rsi),%ymm0
272271

273272
levels0t1 0

proofs/hol_light/x86_64/README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,15 @@ be the code under verification as part of the precondition. For example, the fol
7171
MAYCHANGE [memory :> bytes(a,1024)])`
7272
```
7373

74+
## Platform Compatibility
75+
76+
These x86_64 assembly proofs are expected to work on the following platforms:
77+
78+
- **Linux x86_64**: Fully supported (native build and execution)
79+
- **Linux AArch64**: Not currently supported. Requires x86_64 cross-compilation tools (`x86_64-linux-gnu-as` and `x86_64-linux-gnu-objdump`).
80+
- **macOS x86_64**: Fully supported (native build and execution)
81+
- **macOS ARM (Apple Silicon)**: Not currently supported. Differences in assembler behavior between clang-based (macOS) and gcc-based (Linux) toolchains can cause verification mismatches, particularly with regard to argument ordering optimizations for commutative instructions.
82+
7483
## Reproducing the proofs
7584

7685
To reproduce the proofs, enter the nix shell via

scripts/autogen

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1630,7 +1630,7 @@ def gen_hol_light_asm():
16301630
"ntt.S",
16311631
"mldsa_ntt.S",
16321632
"dev/x86_64/src",
1633-
"-Imldsa/src/native/x86_64/src/ -mavx2 -mbmi2 -msse4 -fcf-protection=none",
1633+
"-Imldsa/src/native/x86_64/src/ -mavx2 -mbmi2 -msse4 -fcf-protection=full",
16341634
),
16351635
]
16361636

0 commit comments

Comments
 (0)