Skip to content

Commit f48f164

Browse files
mkannwischerhanno-becker
authored andcommitted
OQS: Add missing bmi2 flag and clean up
This commit adds the missing bmi2 flag to the ML-DSA-87 yml. bmi2 is currently not strictly needed as asm is not using any bmi2 instructions, but in practice there are no CPUs that have AVX2, but not bmi2 so we might as well keep it as we may use later (as in rejection sampling in mlkem-native) or the compiler may use it. This commit also cleans up ordering of Darwin and Linux in the ymls. Signed-off-by: Matthias J. Kannwischer <[email protected]>
1 parent 8933db9 commit f48f164

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

integration/liboqs/ML-DSA-44_META.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ implementations:
5252
supported_platforms:
5353
- architecture: x86_64
5454
operating_systems:
55-
- Darwin
5655
- Linux
56+
- Darwin
5757
required_flags:
5858
- avx2
5959
- bmi2

integration/liboqs/ML-DSA-65_META.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ implementations:
5252
supported_platforms:
5353
- architecture: x86_64
5454
operating_systems:
55-
- Darwin
5655
- Linux
56+
- Darwin
5757
required_flags:
5858
- avx2
5959
- bmi2

integration/liboqs/ML-DSA-87_META.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,11 @@ implementations:
5252
supported_platforms:
5353
- architecture: x86_64
5454
operating_systems:
55-
- Darwin
5655
- Linux
56+
- Darwin
5757
required_flags:
5858
- avx2
59+
- bmi2
5960
- popcnt
6061
- name: aarch64
6162
version: FIPS204

0 commit comments

Comments
 (0)